Skip to content

Update type/versions supported by st_dbg_ip_driver.c#3171

Merged
fpgamatt merged 1 commit intomasterfrom
fpgamatt/fix-supported-dbg-ip
Jul 25, 2025
Merged

Update type/versions supported by st_dbg_ip_driver.c#3171
fpgamatt merged 1 commit intomasterfrom
fpgamatt/fix-supported-dbg-ip

Conversation

@fpgamatt
Copy link
Contributor

The type and version fields in the dbg-ip were updated recently. Add support for origin and new type and versions.

@fpgamatt fpgamatt self-assigned this Jul 24, 2025
@fpgamatt fpgamatt requested a review from a team as a code owner July 24, 2025 22:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16509153233

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 64.1%

Files with Coverage Reduction New Missed Lines %
libraries/plugins/xfpga/error.c 1 86.7%
Totals Coverage Status
Change from base Build 15210945924: -0.004%
Covered Lines: 15823
Relevant Lines: 24685

💛 - Coveralls

};
struct ver_type supported_ver_types[] = {
{ SUPPORTED_TYPE, SUPPORTED_VERSION, },
{ 0x15244444d, 1, },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a name for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about having #defines for these numbers, but since they are only used in one place, I just put the numbers in the array.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a named device associated with it that would be good to encode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, the dbg_ip is the same, but the version and type numbers were updated.

@michael-adler michael-adler self-requested a review July 25, 2025 18:30
@fpgamatt fpgamatt merged commit 3481cb7 into master Jul 25, 2025
29 checks passed
@fpgamatt fpgamatt deleted the fpgamatt/fix-supported-dbg-ip branch July 25, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants