Skip to content

CIS-3626 DataTables 2#39

Merged
saligiad merged 3 commits intomainfrom
CIS-3626
Mar 12, 2026
Merged

CIS-3626 DataTables 2#39
saligiad merged 3 commits intomainfrom
CIS-3626

Conversation

@saligiad
Copy link
Copy Markdown
Contributor

@saligiad saligiad commented Mar 11, 2026

Overview

Breaking Change

  • Upgrade to DataTables 2.3.7
  • Encapsulate several front-end dependencies used by applications and libraries

Issues

CIS-3626

[X] Added to CHANGELOG.md

Discussion

  • I haven't updated the artifact version just yet, to make things clear between this and the PRs for survey-lib and authlib. Those builds are currently failing, so I'll have to get this published before those builds will succeed.

Breaking Change

* Upgrade to DataTables 2.3.7
* Encapsulate several front-end dependencies used by applications and
  libraries
Comment thread pom.xml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the spring-boot-starter-parent dependency to 3.5.11? We might as well get on the latest patch release.

Comment thread CHANGELOG.md

### Changed

- Upgrade to DataTables 2.3.7 and encapsulate various front-end dependencies (CIS-3626)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update UPGRADING.md to add instructions on what will need to be changed to upgrade applications to this release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, should I create an "Unreleased" heading, or give it a version? In the latter case, would we go with 2.0 here, or 1.9?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use the version number as a heading. You identified that the changes could potentially break dependent applications, which makes this a major version, thus 2.0.0. If you aren't familiar with semantic versioning, it's worth reading the spec (or at least the Wikipedia entry):

Copy link
Copy Markdown
Contributor

@heathharrelson heathharrelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comment on OHSU-OCTRI/authentication-lib#68, this is going the direction that I expect. I'll approve after reviewing your changes to UPGRADING.md.

* Bump to the next major version in `pom.xml`
* Update README.md and UPGRADING.md to reflect new WebJar dependencies
Include instructions in UPGRADING.md to upgrade authlib and survey-lib
to compatible versions.
@saligiad saligiad merged commit 2c34825 into main Mar 12, 2026
2 checks passed
@saligiad saligiad deleted the CIS-3626 branch March 12, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants