Conversation
Update `table-filtering.js` so that the `autoWidth` option is disabled for DataTable instance. This was causing problems with some of the dashboard tables in OPEN, which were not taking up their full container width.
Contributor
|
@saligiad As I understand it, the assignee field is intended to indicate the person who will push a PR ahead until it is merged. In open source projects, this would be someone with rights to merge to the repository. In our team, you have the ability to merge your own PRs, so assigning this to me is inappropriate. I'll review the PR if you like, although you've been working with Amy on this issue and the change looks trivial. |
aeyates
approved these changes
Apr 3, 2026
Contributor
aeyates
left a comment
aeyates
left a comment
There was a problem hiding this comment.
Yes the table-filtering.js script is used when we want to have buttons above the list to do automated filtering. The Notification list utilizes this along with several tables in OPEN. If they all maintain their full width now, then this change is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update
table-filtering.jsso that theautoWidthoption is disabled for DataTable instance. This was causing problems with some of the dashboard tables in OPEN, which were not taking up their full container width.Issues
OPEN-363
[X] Added to CHANGELOG.md
Discussion
Scheduled,Invalid, etc filter buttons on the notifications page? If that's the only place this needs testing, I'll get convert this to normal PR and we should be able to get this merged.Screenshots
With updated common-lib/notification-lib dependencies, my local OPEN instance is still behaving correctly with respect to the filter options:
