-
Notifications
You must be signed in to change notification settings - Fork 1.2k
zynqmp: add flavors for kria starter kits and a platform_banner #7662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
FYI @ricardosalveti |
etienne-lms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment.
Acked-by: Etienne Carriere <etienne.carriere@st.com> once addressed.
| return TEE_SUCCESS; | ||
| } | ||
|
|
||
| service_init(platform_banner); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer add include <initcall.h> at source files entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added #include <initcall.h> and updated the pull request accordingly. Thank you both for your review!
|
With @etienne-lms's comment addressed:
|
99095b6 to
561e018
Compare
|
Please remove the Stuff from the commits, I don't think that will be removed automatically when merging. |
Add PLATFORM_FLAVOR for kd240, kr260 and kv260 kria starter kits. Signed-off-by: Neal Frager <neal.frager@amd.com> Acked-by: Etienne Carriere <etienne.carriere@st.com> Reviewed-by: Ricardo Salveti <ricardo@foundries.io>
Add a platform_banner for zynqmp platforms. Signed-off-by: Neal Frager <neal.frager@amd.com> Acked-by: Etienne Carriere <etienne.carriere@st.com> Reviewed-by: Ricardo Salveti <ricardo@foundries.io>
Done. Thanks! |
No description provided.