Skip to content

Conversation

@nealfrager
Copy link

No description provided.

@github-actions
Copy link

FYI @ricardosalveti

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.
Acked-by: Etienne Carriere <etienne.carriere@st.com> once addressed.

return TEE_SUCCESS;
}

service_init(platform_banner);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer add include <initcall.h> at source files entry.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added #include <initcall.h> and updated the pull request accordingly. Thank you both for your review!

@ricardosalveti
Copy link
Contributor

With @etienne-lms's comment addressed:

Reviewed-by: Ricardo Salveti <ricardo@foundries.io>

@nealfrager nealfrager force-pushed the master branch 2 times, most recently from 99095b6 to 561e018 Compare January 9, 2026 07:34
@jenswi-linaro
Copy link
Contributor

Please remove the

---
V1->V2:

Stuff from the commits, I don't think that will be removed automatically when merging.

Add PLATFORM_FLAVOR for kd240, kr260 and kv260 kria starter kits.

Signed-off-by: Neal Frager <neal.frager@amd.com>
Acked-by: Etienne Carriere <etienne.carriere@st.com>
Reviewed-by: Ricardo Salveti <ricardo@foundries.io>
Add a platform_banner for zynqmp platforms.

Signed-off-by: Neal Frager <neal.frager@amd.com>
Acked-by: Etienne Carriere <etienne.carriere@st.com>
Reviewed-by: Ricardo Salveti <ricardo@foundries.io>
@nealfrager
Copy link
Author

Please remove the

---
V1->V2:

Stuff from the commits, I don't think that will be removed automatically when merging.

Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants