Add regression_4018: TEE_SetOperationKey() panic #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Depends on OP-TEE/optee_os#7656. |
jforissier
force-pushed
the
setkey-panic
branch
from
21578dc to
38345ab
Compare
host/xtest/xtest_helpers.c
Outdated
| exp_ret_orig = TEEC_ORIGIN_TEE; | ||
| else | ||
| exp_ret_orig = TEEC_ORIGIN_TRUSTED_APP; | ||
| (void)ADBG_EXPECT_TEEC_ERROR_ORIGIN(c, exp_ret_orig, ret_orig); |
Contributor
There was a problem hiding this comment.
Please drop the (void) cast.
Contributor
jenswi-linaro
left a comment
jenswi-linaro
left a comment
There was a problem hiding this comment.
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
According to the TEE Internal Core API specification v1.3.1 section 6.2.6, TEE_SetOperationKey() should panic if the flag TEE_HANDLE_FLAG_INITIALIZED is set on the operation. Add regression test 4018 to check that. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
jforissier
force-pushed
the
setkey-panic
branch
from
8bc520a to
fa5188f
Compare
Free up some disk space in the GitHub Actions VM before building the Docker image for the subsequent job. Do the same before loading the image and running the tests. Fixes "no space left on device" errors. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
jforissier
force-pushed
the
setkey-panic
branch
from
fa5188f to
6f5e6b1
Compare
Contributor
Author
|
CI commit updated to also run the host cleanup script in the QEMUv8_checks job in addition to QEMUv8_checks_image_build. Both are subject to "no space left on device" errors. @jenswi-linaro I have kept your Acked-by. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the TEE Internal Core API specification v1.3.1 section 6.2.6, TEE_SetOperationKey() should panic if the flag TEE_HANDLE_FLAG_INITIALIZED is set on the operation. Add regression test 4018 to check that.