Skip to content

make cmake tests tolerable #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgallagher59701 merged 17 commits into from
Jan 6, 2026
Merged

make cmake tests tolerable #329

jgallagher59701 merged 17 commits into from
Jan 6, 2026

Conversation

@jgallagher59701
Copy link
Member

@jgallagher59701 jgallagher59701 commented Jan 6, 2026 •
edited
Loading

This is for GitHub issue 328 which is on branch Jhrg/gh 328 make cmake tests tolerable

This PR adds better support for tests to the cmake build.

There are some issues to be resolved:

  1. The integration (autotest) tests are handled two ways. One way uses cmake add_test(COMMAND <set of shell commands like 'sed'>) and the other moves all of that into a secondary shell script. The latter adds another moving part, but is easier to debug. Choose one and do the same thing everywhere? Maybe that is expecting too perfect a world?
  2. Once this is merged, close out HYRAX-???? that describes the issue where dmr-test and expr-test don't support parallel tests (this branch adds that feature).

@jgallagher59701
Remove integration test .out files for das tests
e14c761
@jgallagher59701
Added baseline generation for the das tests
571b198
@jgallagher59701
Improved baseline generation for the das tests
d97ffd7
@jgallagher59701
Removed .out files for getdap tests
7ce2c71
@jgallagher59701
Added baseline generation for the getdap tests
ab99a51
@jgallagher59701
Added .out removal and baseline generation for the dds tests
2125f99
@jgallagher59701
Removed .out files for most of the dmr and expr tests.
e2d2247 
Some are not being removed; don't know why exactly, but xfail
tests are nore removed.
@jgallagher59701
Fixed the expr tests stray .out file bug
b381803
@jgallagher59701
dmr tests .out files: WIP
cd9bc98
@jgallagher59701
dmr tests: WIP
bc6ec7c
@jgallagher59701
dmr tests: WIP, better version for baseline updates.
989a30b
@jgallagher59701
Merged and fixed up the new DMR test scheme.
1765379 
This moves the test COMMAND to a bash script, adding a level of
indirection but simplifying debugging.
@jgallagher59701
Fix dmr_test.cc send_data() to use TempFile
a013259
@jgallagher59701
dmr-test and expr-test now support parallel tests
0d9f917
@jgallagher59701
Added (but not configured) a unit test for TempFile
2ebd9aa
@jgallagher59701
Added TempFileTest unit test to the cmake build
be5e4dd
@jgallagher59701
pre-commit needed to be run
432005b
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ndp-opendap
ndp-opendap approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@ndp-opendap ndp-opendap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So. Much. CMake.

:shipit:

@jgallagher59701 jgallagher59701 marked this pull request as ready for review January 6, 2026 17:54
@jgallagher59701 jgallagher59701 merged commit 3be6b44 into master Jan 6, 2026
5 checks passed
@jgallagher59701 jgallagher59701 deleted the jhrg/gh-328-make-cmake-tests-tolerable branch January 6, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndp-opendap ndp-opendap ndp-opendap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgallagher59701 @ndp-opendap