Use of additional MADOF in projection and extraction of scalar field on mixed basis#286
Merged
kmokstad merged 5 commits intoOPM:masterfrom Sep 7, 2018
Merged
Use of additional MADOF in projection and extraction of scalar field on mixed basis#286kmokstad merged 5 commits intoOPM:masterfrom
kmokstad merged 5 commits intoOPM:masterfrom
Conversation
Contributor
Author
|
jenkins build this with downstreams ifem-openfrac=4 please |
Contributor
Author
|
jenkins build this with downstreams ifem-openfrac=4 please |
to tap into the additional MADOFs for mixed problems. Assume the scalar field always is on the first basis.
to tap into the additional MADOFs for mixed problems. Changed: The [extract|inject]PatchSolution methods do not need to check both nndof>0 and basis>0. The latter check is sufficient. Also invoke the getNoFields method on the patch in question instead of for *this (which implies the first patch always). Fixed: Missing basis in the injectNodeVec call in injectPatchSolution. Added: Check consistency in additional MADOF for multi-patch models, in the similar ways as in SAMPatch::initNodeDofs.
with a dependent scalar field defined on one of its bases
Let [extract|inject]NodalVec return false if the test fails.
Also the non-BLAS version of this multiply method was faulty. Changed: Use const reference only for those parameters that are passed into BLAS subroutines (consistency). Changed: Clear the matrix if dimension mismatch is detected in the multiply methods returning the reference to the matrix itself (for error handling).
Contributor
Author
|
jenkins build this with downstreams ifem-openfrac=4 ifem-poroelasticity=27 please |
Contributor
Author
|
jenkins build this with downstreams ifem-poroelasticity=27 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Except for the last one these commits are slightly modified versions of https://github.com/akva2/IFEM/tree/fix_expl_mixed. The main difference being the overloaded registerDependency method in SIMbase, instead of exposing getMADOF method to public. Also some more range-based for loops here and there.
This is now required by OPM/IFEM-OpenFrac#4 with the last commit there.