Add Undersaturated State Handling in Table Initialisation #4621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bska
added
the
manual:bugfix
Member
Author
Member
Author
|
jenkins build this failure_report please |
bska
force-pushed
the
fill-usat-states
branch
9 times, most recently
from
fb3235f to
c6c9368
Compare
Member
Author
|
jenkins build this only_summary please |
Member
Author
|
jenkins build this opm-simulators=6315 only_summary failure_report please |
bska
force-pushed
the
fill-usat-states
branch
2 times, most recently
from
80a26b2 to
9a25a55
Compare
bska
force-pushed
the
fill-usat-states
branch
9 times, most recently
from
09a83a2 to
7d8cd77
Compare
bska
force-pushed
the
fill-usat-states
branch
4 times, most recently
from
d50508e to
92049ec
Compare
bska
force-pushed
the
fill-usat-states
branch
5 times, most recently
from
ac7fd15 to
2bcd55c
Compare
bska
force-pushed
the
fill-usat-states
branch
3 times, most recently
from
d19faaf to
5d6207f
Compare
bska
force-pushed
the
fill-usat-states
branch
10 times, most recently
from
453498c to
1f0805d
Compare
bska
force-pushed
the
fill-usat-states
branch
8 times, most recently
from
62b76b7 to
6f81961
Compare
bska
force-pushed
the
fill-usat-states
branch
2 times, most recently
from
e156af0 to
f1c18e6
Compare
This commit adds a procedure for expanding missing undersaturated
states in PVTO/PVTG in the low-level Pvt*Table classes on top of
which the higher level types are built. This, as an added benefit,
directly ensures that we emit fully expanded PVTO/PVTG tables to the
.INIT file.
To this end, equip the base class PvtxTable with a helper function
void PvtxTable::populateMissingUndersaturatedStates()
which will invoke the virtual function
makeScaledUSatTableCopy(src, dest)
in its derived classes--especially PvtoTable and PvtgTable--for each
missing undersaturated state. The type-specific procedures for
PvtoTable and PvtgTable is defined in such a way that the scaled
copies preserve oil compressibility.
bska
force-pushed
the
fill-usat-states
branch
from
f1c18e6 to
538e53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a procedure for expanding missing undersaturated states in PVTO/PVTG in the low-level
Pvt*Tableclasses on top of which the higher level types are built. This, as an added benefit, directly ensures that we emit fully expanded PVTO/PVTG tables to the .INIT file.To this end, equip the base class
PvtxTablewith a helper functionwhich will invoke the virtual function
in its derived classes–especially
PvtoTableandPvtgTable–for each missing undersaturated state. The type-specific procedures forPvtoTableandPvtgTableis defined in such a way that the scaled copies preserve oil compressibility.This PR completes PVT table output and (finally) closes #694.