Expose Foam Density Unit #4842
Open
Expose Foam Density Unit #4842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new UnitSystem::measure for "foam density" quantities such as those entered in the WFOAM keyword. This is mainly intended for client code that wishes to tag output arrays appropriately for unit conversion in restart file output. While here, also add unit tests for the 'concentration' unit of measure that was introduced in commit d4e33a4 (PR OPM#4741).
bska
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
bska
added a commit
to bska/opm-simulators
that referenced
this pull request
Nov 28, 2025
The FOAM result array should be treated as a "foamdensity" (PR OPM/opm-common#4842) instead of a saturation when converted to output units.
Member
|
The PR looks good, while not directly related to this PR, from the manual I read, it looks like |
GitPaean
reviewed
Nov 28, 2025
| "GPa", | ||
| "KJ/M/DAY/K", | ||
| "DAY/SM3", | ||
| "KG/SM3", |
Member
There was a problem hiding this comment.
not all the units have that, but I do think a comment can help the readability and also you are here to adding a new one, since it is a relatively long list now.
"KG/SM3", /* foam density */ something like that.
GitPaean
approved these changes
Nov 28, 2025
Member
GitPaean
left a comment
GitPaean
left a comment
There was a problem hiding this comment.
Thanks for the PR, it looks good to me. A small comment regarding comment, I will leave it up to you whether to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
UnitSystem::measurefor "foam density" quantities such as those entered in theWFOAMkeyword. This is mainly intended for client code that wishes to tag output arrays appropriately for unit conversion in restart file output.While here, also add unit tests for the 'concentration' unit of measure that was introduced in commit d4e33a4 (PR #4749).