[LGR] Remove obsolete LGR functions #4875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
jenkins build this please |
akva2
added
the
manual:irrelevant
Member
Author
|
@akva2 thank you, my friend. |
Member
Author
|
jenkins build this please |
Member
Author
bska
reviewed
Dec 19, 2025
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Much appreciated. Just a couple of minor points regarding the unit test.
review suggestions
arturcastiel
force-pushed
the
lgr-remove-obsolete-func
branch
from
37c9cf9 to
ed7112f
Compare
Member
Author
|
jenkins build this please |
bska
approved these changes
Dec 19, 2025
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Thanks a lot for the updates. This looks good to me now and I'll merge into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that removes functions that became obsolete once LGR COORD and ZCORN were defined inside opm-common .