Skip to content

Conversation

@michal-toth
Copy link
Contributor

@michal-toth michal-toth commented May 12, 2025

The parameter --allow-distributed-wells was till this commit ignored, it was always set to false. With these changes, the value true makes the partitioner completely ignore wells, the partitions are calculated as if there were no wells. It is possible to obtain partitioning that has one or more wells split over multiple subdomains.

Internally, setting --allow-distributed-wells=true makes the partitioner skip the vertex contraction step in the graph representation of the grid, where cells of each well were merged to one (which prevented the partitioning algorithm from splitting any well).

Documentation changes: Partitioner zoltanwell (default) no longer ignores the allow-distributed-wells. This makes its behavior more similar to other partitioners.

@lisajulia lisajulia added the manual:new-feature This is a new feature and should be described in the manual label May 12, 2025
@lisajulia
Copy link

jenkins build this please

@lisajulia
Copy link

lisajulia commented May 12, 2025

@michal-toth: I've tested this with NORNE and it looks similar (unfortunately not quite as good as) what I have with #824. Thanks!
Can you please:

  • rebase this on master (I tried and got some failures)
  • clean the commit history (i.e. remove merge commits and commits where conflicts are resolved)
    Thanks!

@atgeirr
Copy link
Member

atgeirr commented May 12, 2025

This PR does not require any code changes to work with OPM/opm-simulators#6264 if that is merged, but it will change testing (and also the title of this PR would be wrong...) so be aware.

@michal-toth michal-toth changed the title Allow distributed wells with partition-method 3 Allow distributed wells with partition method zoltanwell May 12, 2025
@michal-toth michal-toth force-pushed the feature/graph-of-grid-second-try branch from 19fe425 to deddeaa Compare May 12, 2025 13:16
@michal-toth
Copy link
Contributor Author

jenkins build this serial please

@michal-toth michal-toth force-pushed the feature/graph-of-grid-second-try branch from deddeaa to 0425b03 Compare May 14, 2025 08:54
@michal-toth michal-toth marked this pull request as ready for review May 14, 2025 08:55
@lisajulia
Copy link

@michal-toth: I would love to merge this, but can you clean the commit history before, i.e. rebase this once more and remove merge commits? Thanks!

@michal-toth
Copy link
Contributor Author

@michal-toth: I would love to merge this, but can you clean the commit history before, i.e. rebase this once more and remove merge commits? Thanks!

The merge commits are gone. However, commit messages got messed up, I will look up how to amend them.

@akva2
Copy link
Member

akva2 commented May 15, 2025

git rebase -i origin/master, replace 'pick' with 'r(eword)'.

@michal-toth michal-toth force-pushed the feature/graph-of-grid-second-try branch from 0425b03 to 643e81c Compare May 15, 2025 07:00
@lisajulia
Copy link

Thanks!

@lisajulia
Copy link

jenkins build this serial please

@lisajulia lisajulia merged commit 1affdfa into OPM:master May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:new-feature This is a new feature and should be described in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants