-
Notifications
You must be signed in to change notification settings - Fork 78
Allow distributed wells with partition method zoltanwell
#874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow distributed wells with partition method zoltanwell
#874
Conversation
|
jenkins build this please |
|
@michal-toth: I've tested this with NORNE and it looks similar (unfortunately not quite as good as) what I have with #824. Thanks!
|
|
This PR does not require any code changes to work with OPM/opm-simulators#6264 if that is merged, but it will change testing (and also the title of this PR would be wrong...) so be aware. |
zoltanwell
19fe425 to
deddeaa
Compare
|
jenkins build this serial please |
deddeaa to
0425b03
Compare
|
@michal-toth: I would love to merge this, but can you clean the commit history before, i.e. rebase this once more and remove merge commits? Thanks! |
The merge commits are gone. However, commit messages got messed up, I will look up how to amend them. |
|
git rebase -i origin/master, replace 'pick' with 'r(eword)'. |
0425b03 to
643e81c
Compare
|
Thanks! |
|
jenkins build this serial please |
The parameter
--allow-distributed-wellswas till this commit ignored, it was always set tofalse. With these changes, the valuetruemakes the partitioner completely ignore wells, the partitions are calculated as if there were no wells. It is possible to obtain partitioning that has one or more wells split over multiple subdomains.Internally, setting
--allow-distributed-wells=truemakes the partitioner skip the vertex contraction step in the graph representation of the grid, where cells of each well were merged to one (which prevented the partitioning algorithm from splitting any well).Documentation changes: Partitioner
zoltanwell(default) no longer ignores theallow-distributed-wells. This makes its behavior more similar to other partitioners.