Make entity marking dune conformant #947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the entity marking process conforms to dune interface by adding a boolean flag that defines whether to throw an exception when the marking is invalid or not. If false, the function returns gracefully as the dune-grid interface expects. If true, the function will throw a message with the reason of the failure.
SoilRos
added
enhancement
manual:irrelevant
Member
Author
|
jenkins build this please |
aritorto
reviewed
Nov 19, 2025
Member
aritorto
left a comment
aritorto
left a comment
There was a problem hiding this comment.
Nice fix towards being able to run the DUNE Grid test! Only one question and minor suggestions
| // Mark all the elements of the current leaf grid view for refinement | ||
| mark(1, element); | ||
| assignRefinedLevel[element.index()] = preAdaptMaxLevel +1; | ||
| if (mark(1, element)) |
Member
There was a problem hiding this comment.
Is there any reason why here we do not add the throwOnFailure flag with true? I would say we want to throw if the element is at the boundary of an LGR
| mark(1, element); | ||
| assignRefinedLevel[element.index()] = preAdaptMaxLevel +1; | ||
| if (mark(1, element)) | ||
| assignRefinedLevel[element.index()] = preAdaptMaxLevel +1; |
| auto assignAndDetect = [this, &assignRefinedLevel, &lgr_with_at_least_one_active_cell](const cpgrid::Entity<0>& element, int level) | ||
| { | ||
| mark(1, element); | ||
| mark(1, element, true); |
Member
There was a problem hiding this comment.
Could you please add /* throwOnFailure = */ before true? So it's easier to read/understand
| } | ||
| if(belongsToLevel) { | ||
| this->mark(1, element); | ||
| this->mark(1, element, true); |
Member
There was a problem hiding this comment.
Same here (the suggestion of /* throwOnFailure = */ true) and in the other files too, please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the entity marking process conforms to dune interface by adding a boolean flag that defines whether to throw an exception when the marking is invalid or not.
If the flag is false, the function returns gracefully as the dune-grid interface expects. If true, the function will throw a message with the reason of the failure. The default flag (false) follows the dune interface.
In cases where the LGR is explicitly requested by the user, the flag is set to true to still provide useful diagnostics.