Skip to content

Conversation

@aritorto
Copy link
Member

@aritorto aritorto commented Dec 1, 2025

This PR follows up on #945, which introduced a method for extracting data::Solution and restart values from the leaf grid back to the level grids. In that implementation, cells that disappeared during refinement (i.e., parent cells) were assigned “rubbish” values.

This PR replaces those "rubbish" values with the average of the corresponding children’s data. At the moment, all named data fields are handled using this averaging approach. In future work, we plan to refine this behavior for specific field properties that may require different aggregation methods.

@aritorto aritorto added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Dec 1, 2025
@aritorto
Copy link
Member Author

aritorto commented Dec 1, 2025

jenkins build this opm-simulators=6642 serial please

@aritorto aritorto changed the title Assign average value for parent cells, in restartValue props Assign average output values for parent cells Dec 2, 2025
@aritorto aritorto force-pushed the averageVanishedCells branch 3 times, most recently from bc40dd0 to e5d17b6 Compare December 2, 2025 09:10
@aritorto
Copy link
Member Author

aritorto commented Dec 2, 2025

jenkins build this serial please

@aritorto
Copy link
Member Author

aritorto commented Dec 2, 2025

jenkins build this opm-simulators=6642 serial please

@aritorto
Copy link
Member Author

aritorto commented Dec 2, 2025

jenkins build this serial please

@aritorto
Copy link
Member Author

aritorto commented Dec 2, 2025

jenkins build this opm-simulators=6642 serial nompi please

1 similar comment
@aritorto
Copy link
Member Author

aritorto commented Dec 3, 2025

jenkins build this opm-simulators=6642 serial nompi please

@aritorto
Copy link
Member Author

aritorto commented Dec 4, 2025

jenkins build this opm-simulators=6642 serial please

@aritorto
Copy link
Member Author

aritorto commented Dec 4, 2025

jenkins build this opm-simulators=6642 serial please

@aritorto aritorto mentioned this pull request Dec 4, 2025
@aritorto aritorto force-pushed the averageVanishedCells branch 2 times, most recently from 9e39aad to dcc659f Compare December 8, 2025 09:58
@aritorto
Copy link
Member Author

aritorto commented Dec 8, 2025

jenkins build this opm-simulators=6642 serial please

@aritorto aritorto force-pushed the averageVanishedCells branch from dcc659f to 49420f8 Compare December 9, 2025 07:57
@aritorto
Copy link
Member Author

aritorto commented Dec 9, 2025

jenkins build this opm-simulators=6642 serial please

@aritorto aritorto marked this pull request as draft December 9, 2025 15:30
@aritorto aritorto force-pushed the averageVanishedCells branch 3 times, most recently from dd69899 to 34fc5b5 Compare December 15, 2025 17:13
@aritorto aritorto marked this pull request as ready for review December 15, 2025 17:14
@aritorto
Copy link
Member Author

jenkins build this opm-simulators=6642 serial please

@aritorto
Copy link
Member Author

jenkins build this serial please

@aritorto
Copy link
Member Author

jenkins build this opm-simulators=6642 serial please

@aritorto aritorto force-pushed the averageVanishedCells branch 2 times, most recently from 06a5536 to bfbbe67 Compare December 19, 2025 14:55
@aritorto
Copy link
Member Author

jenkins build this serial please

@aritorto aritorto force-pushed the averageVanishedCells branch from bfbbe67 to 327f2e7 Compare December 19, 2025 15:01
@aritorto
Copy link
Member Author

jenkins build this serial please

Copy link
Member

@blattms blattms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@blattms blattms merged commit 459e314 into OPM:master Dec 19, 2025
2 checks passed
@aritorto aritorto deleted the averageVanishedCells branch December 29, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants