Extract trans values for level zero cells that appearon leaf grid #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritorto
added
the
manual:irrelevant
aritorto
force-pushed
the
level0Trans
branch
from
c9a690d to
749efe9
Compare
Member
Author
|
jenkins build this opm-simulators=6661 serial please |
aritorto
force-pushed
the
level0Trans
branch
2 times, most recently
from
2d765ae to
2980349
Compare
Member
Author
|
jenkins build this opm-simulators=6661 serial please |
aritorto
force-pushed
the
level0Trans
branch
from
2980349 to
253035b
Compare
Member
Author
|
jenkins build this opm-simulators=6661 serial please |
blattms
requested changes
Dec 23, 2025
Member
blattms
left a comment
blattms
left a comment
There was a problem hiding this comment.
If it turns out that we need this, then we will need to address the issue with the superfluous container.
opm/grid/cpgrid/LgrOutputHelpers.hpp
Outdated
| int maxCartIdx = std::max(cartIdxIn, cartIdxOut); | ||
|
|
||
| if (maxCartIdx - minCartIdx == 1 && cartDims[0] > 1 ) { | ||
| tranx.template data<double>()[cartIdxIn] += leafTrans.transmissibility(leafIdxIn, leafIdxOut); |
| if constexpr (std::is_same_v<Grid, Dune::CpGrid>) { | ||
| // To detect direct vertical neighboring cells: | ||
| const Opm::LevelCartesianIndexMapper<Dune::CpGrid> levelCartMapp(grid); | ||
| const auto levelCartToLevelCompressed = Opm::Lgr::levelCartesianToLevelCompressedMaps(grid, levelCartMapp); |
Member
There was a problem hiding this comment.
Two comments here:
- If we only need level 0 then we should not set up all the other levels
- The map that we are using in opm-simulators already seems the one that we need here. This due to our cartesian index on the leaf grid (same as the one of the parent on level 0) and the fact that this map from global to compressed index is only used to check whether it contains a global index (See function directVerticalNeighbour
Hence I think that we do not need this container at all.
opm/grid/cpgrid/LgrOutputHelpers.hpp
Outdated
Comment on lines
397
to
398
| int minCartIdx = std::min(cartIdxIn, cartIdxOut); | ||
| int maxCartIdx = std::max(cartIdxIn, cartIdxOut); |
Member
There was a problem hiding this comment.
Nitpic: I think the result should be clear because of the if statement above.
aritorto
force-pushed
the
level0Trans
branch
from
253035b to
9116df6
Compare
aritorto
force-pushed
the
level0Trans
branch
from
9116df6 to
1630890
Compare
Member
Author
|
Closing since OPM/opm-simulators#6706 does the job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a method to extract TRANS* from the leaf grid to the level zero grid. For now, refined cells and cells that vanished during refinement, i.e., parent cells, are not considered. This will be improved and corrected in future PRs.
Keywords: LGRs, output file INIT