Skip to content

Support simulation with CARFIN enabling ecl output #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aritorto wants to merge 2 commits into from
Closed

Support simulation with CARFIN enabling ecl output #6642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6592e
Create output grid with COORD and ZCORN lgrs.
aritorto Nov 28, 2025
e456304
Reduce duplication with optional output_grid
aritorto Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 62 additions & 16 deletions opm/simulators/flow/EclGenericWriter_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

#include <dune/grid/common/mcmgmapper.hh>


#include <opm/grid/cpgrid/CpGridUtilities.hpp>
#include <opm/grid/cpgrid/LgrOutputHelpers.hpp>
#include <opm/grid/GridHelpers.hpp>
#include <opm/grid/utility/cartesianToCompressed.hpp>
Expand Down Expand Up @@ -236,20 +238,63 @@ EclGenericWriter(const Schedule& schedule,
, equilGrid_ (equilGrid)
{
if (this->collectOnIORank_.isIORank()) {
this->eclIO_ = std::make_unique<EclipseIO>
(this->eclState_,
UgGridHelpers::createEclipseGrid(*equilGrid, eclState_.getInputGrid()),
this->schedule_, summaryConfig, "", enableEsmry);
}

// create output thread if enabled and rank is I/O rank
// async output is enabled by default if pthread are enabled
int numWorkerThreads = 0;
if (enableAsyncOutput && collectOnIORank_.isIORank()) {
numWorkerThreads = 1;
}
std::optional<Opm::EclipseGrid> output_grid;

if constexpr (std::is_same_v<Grid, Dune::CpGrid>) {
// For CpGrid with LGRs, we generate an EclipseGrid for output using grid_
// rather than equilGrid_. When equilGrid_ is created as a shallow copy of
// grid_, some internal data members are not propagated. As a result,
// equilGrid_ lacks the necessary LGR information, and ResInsight cannot
// visualize the local grids.
//
// TODO: Resolve this by improving the CpGrid copy constructor or by introducing
// an alternative mechanism to ensure all relevant grid data is fully transferred.
if ( (this->grid_.comm().size() == 1) && (this->eclState_.getLgrs().size()>0) && (this->grid_.maxLevel()>0) ) {

// Create a new EclpseGrid for output using dims and zcorn and coords from level zero
const auto [l0CartesianIdxToCellIdx, l0IJK] = Opm::lgrIJK(grid_, "GLOBAL");
const auto [l0COORD, l0ZCORN] = Opm::lgrCOORDandZCORN(grid_, 0, l0CartesianIdxToCellIdx, l0IJK);
Opm::EclipseGrid eclipse_grid_output(grid_.logicalCartesianSize(), l0COORD, l0ZCORN);

// Set the LGRCollection
eclipse_grid_output.init_lgr_cells(eclState_.getLgrs());

// Loop over all levels
for (const auto& [lgr_name, lgr_level] : grid_.getLgrNameToLevel())
{
const auto [lgrCartesianIdxToCellIdx, lgrIJK] = Opm::lgrIJK(grid_, lgr_name);
const auto [lgrCOORD, lgrZCORN] = Opm::lgrCOORDandZCORN(grid_, lgr_level, lgrCartesianIdxToCellIdx, lgrIJK);

this->taskletRunner_.reset(new TaskletRunner(numWorkerThreads));
eclipse_grid_output.set_lgr_refinement(lgr_name, lgrCOORD, lgrZCORN);
}
eclipse_grid_output.init_children_host_cells();

output_grid = std::move(eclipse_grid_output);
}
}
// CpGrid without LGR or different grid type
if (!output_grid) {
output_grid = UgGridHelpers::createEclipseGrid(*equilGrid, eclState_.getInputGrid());
}

this->eclIO_ = std::make_unique<EclipseIO>(this->eclState_,
*output_grid,
this->schedule_,
summaryConfig,
"",
enableEsmry);


// create output thread if enabled and rank is I/O rank
// async output is enabled by default if pthread are enabled
int numWorkerThreads = 0;
if (enableAsyncOutput && collectOnIORank_.isIORank()) {
numWorkerThreads = 1;
}

this->taskletRunner_.reset(new TaskletRunner(numWorkerThreads));
}
}

template<class Grid, class EquilGrid, class GridView, class ElementMapper, class Scalar>
Expand Down Expand Up @@ -615,14 +660,15 @@ doWriteOutput(const int reportStepNum,
}
}

std::vector<Opm::RestartValue> restartValues{};
// only serial, only CpGrid (for now)
std::vector<Opm::RestartValue> restartValues{}; // Level grids RestartValues (only serial and CpGrid for now)
if ( !isParallel && !needsReordering && (this->eclState_.getLgrs().size()>0) && (this->grid_.maxLevel()>0) ) {
// Level cells that appear on the leaf grid view get the data::Solution values from there.
// Other cells (i.e., parent cells that vanished due to refinement) get rubbish values for now.
// Other cells (i.e., parent cells that vanished due to refinement) get average of children values for now.
// Only data::Solution is restricted to the level grids. Well, GroupAndNetwork, Aquifer are
// not modified in this method.
Opm::Lgr::extractRestartValueLevelGrids<Grid>(this->grid_, restartValue, restartValues);
Opm::Lgr::extractRestartValueLevelGrids<Grid>(this->grid_,
restartValue,
restartValues);
}
else {
restartValues.reserve(1); // minimum size
Expand Down