Ensure correct summary output for iteration counts. #6720
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atgeirr
added
the
manual:bugfix
Member
Author
|
jenkins build this please |
akva2
reviewed
Jan 9, 2026
| full_report += substep_report; | ||
| problem.setSimulationReport(full_report); | ||
| // This also runs the evalSummary() and action updates. | ||
| problem.endStepApplyAction(); |
Member
There was a problem hiding this comment.
Not sure it is relevant right now, but FlowProblemComp does not have this method.
Member
Author
There was a problem hiding this comment.
I see it is all done in endTimeStep(). If we do the same modification there it should become correct.
The test failures are all expected (only modifying the data I wanted to) except the last one (flowexp_blackoil_SPE1CASE2) which I will need to investigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary NEWTON array (and similar) is off by one, and wrong after a timestep cut.