Skip to content

Conversation

@plgbrts
Copy link
Contributor

@plgbrts plgbrts commented Nov 19, 2025

This is a test case for the functionality as implemented in the PRs OPM/opm-simulators#6368 and OPM/opm-common#4656

Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test case for the functionality as implemented in the PRs OPM/opm-simulators#6368 and OPM/opm-common#4656

Thanks–this is greatly appreciated and we'll merge this into the master branch once a couple of minor issues have been addressed.

You might also wish to look at the comments that discuss units of measurement. The comments refer to FIELD units while the case is in METRIC units.

2575.56 9 /

RSVD
-- Dissolved GOR is initially constant with depth through the reservoir.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: This table has an initial dissolved GOR that varies with the depth so the comment does not agree with the data. Maybe you could fix that before we merge this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it

/

TSTEP
--Advance the simulater once a month for TEN years:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment does not agree with the data. Maybe you could fix that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@plgbrts
Copy link
Contributor Author

plgbrts commented Nov 20, 2025

Thanks @bska for the review. I addressed your suggestions.

Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed your suggestions.

Thanks a lot for the updates. This looks good to me now and I'll merge into master.

@bska bska merged commit c5c8cb9 into OPM:master Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants