-
Notifications
You must be signed in to change notification settings - Fork 62
test case for the combination Brine and Thermal #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test case for the functionality as implemented in the PRs OPM/opm-simulators#6368 and OPM/opm-common#4656
Thanks–this is greatly appreciated and we'll merge this into the master branch once a couple of minor issues have been addressed.
You might also wish to look at the comments that discuss units of measurement. The comments refer to FIELD units while the case is in METRIC units.
| 2575.56 9 / | ||
|
|
||
| RSVD | ||
| -- Dissolved GOR is initially constant with depth through the reservoir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit: This table has an initial dissolved GOR that varies with the depth so the comment does not agree with the data. Maybe you could fix that before we merge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
| / | ||
|
|
||
| TSTEP | ||
| --Advance the simulater once a month for TEN years: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment does not agree with the data. Maybe you could fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Thanks @bska for the review. I addressed your suggestions. |
bska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed your suggestions.
Thanks a lot for the updates. This looks good to me now and I'll merge into master.
This is a test case for the functionality as implemented in the PRs OPM/opm-simulators#6368 and OPM/opm-common#4656