Projected gaussian source #78
Conversation
There was a problem hiding this comment.
Quick review while still in draft state. Looks good from reading through the code, but request a re-review once this exist draft state and I'll test it.
If you have any references for the origin of the mathematical form, would be good to include them in the source code somewhere for documentation.
| heatSourceModelCoeffs_ = optionalSubDict(type() + "Coeffs"); | ||
|
|
||
| //- Mandatory entries | ||
| heatSourceModelCoeffs_.lookup("A") >> A_; | ||
| heatSourceModelCoeffs_.lookup("B") >> B_; |
There was a problem hiding this comment.
Isn't optionalSubDict contradictory with the mandatory entries comment?
There was a problem hiding this comment.
@kincaidkc - this is carried over from the original refactor of the heatSourceClass to handle polymorphism. Do you remember why we are using optionalSubDict here? I know that there are several examples in OpenFOAM-10 using this method for similar uses, (example) but haven't tested changing this yet.
There was a problem hiding this comment.
It lets you put the coefficients inside or outside of the subdictionary. For model-specific stuff we should probably require a subdictionary.
There was a problem hiding this comment.
@kincaidkc, so optionalSubDict should be moved to subDict if we want to make sure that mandatory entries are read from type()Coeffs? I can test this out, but we will probably was to create a PR to do this for all derived heatSourceModels and absorptionModels.
We don't have a citation for the mathematical form yet. It is the focus of a manuscript I am currently preparing. |
3 participants
Projects gaussian heat source which uses a supergaussian axial decay function, where the coefficient on the decay function can be specified as a function of the heat source aspect ratio (a), such that: n = A*log2(a) + B