Skip to content

Fixed skip matrix in examples#407

Merged
pelesh merged 3 commits intodevelopfrom
shaked/remove_0th_mat_examples
Feb 6, 2026
Merged

Fixed skip matrix in examples#407
pelesh merged 3 commits intodevelopfrom
shaked/remove_0th_mat_examples

Conversation

@shakedregev
Copy link
Collaborator

@shakedregev shakedregev commented Feb 6, 2026

Description

Currently our examples do a complete factorization at matrix number 1. This is because matrix 0's pivoting sequence does not work for the rest of the sequence. This creates the misconception that it is necessary to fully factorize twice before refactorization for users.

Proposed changes

I removed the pathological 0 matrix from the examples. Matrices should now be 1 indexed (as opposed to 0 indexed).

Checklist

  • All tests pass (make test and make test_install per testing instructions). Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run:
    ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@pelesh pelesh added good first issue Good for newcomers examples labels Feb 6, 2026
@pelesh pelesh added this to the Release 0.99.3 milestone Feb 6, 2026
@pelesh pelesh removed the request for review from nkoukpaizan February 6, 2026 16:52
@pelesh pelesh merged commit b5d1f31 into develop Feb 6, 2026
@shakedregev shakedregev deleted the shaked/remove_0th_mat_examples branch February 6, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants