Open
Conversation
- Refactored in order to keep node content near node creation for hopefully easier reading. - Added beginning stages of conditional logic for optional and conditional nodes. Logic will be completed after more definite design decisions are made between myself (Ross) and Michael.
- Changed all auto declarations to pugi::xml_node
- Still requires correct geocode node content. Will implement in the next push. - Still needs thorough testing.
Fea 287 task 298
- Fixed some linting issues. - NOTE: This file does not compile for some unknown reason. This push is to allow other team members to test it on their machines as well.
- NOTE: The odd formatting is to allow this to pass linting. It's hideous and I hate it, but it is what it is.
- NOTE: The odd formatting is to allow this to pass linting. It's hideous and I hate it, but it is what it is.
- NOTE: The odd formatting is to allow this to pass linting. It's hideous and I hate it, but it is what it is.
- NOTE: Values found in the example object are not all valid in the CMAC spec. This object's purpose is solely to test that all convert function functionality is present. - Fixed various convert function errors relating to std::optional objects. - Updated the README.md in the soap/cmac-conversion directory to reflect how the cmac_converter is currently compiled and run.
- Cleaned up cmac_converter.cpp code formatting and shifted appropriate TODO items to cmac_alert.hpp. - Updated CMAC_cap_geocode to a vector of std::pair<std::string, std::string>.
Fea 287 task 305
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.