Skip to content

Fix some out of bounds errors with the epsilon merging from q files. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessecusack merged 2 commits into from
Mar 21, 2026
Merged

Fix some out of bounds errors with the epsilon merging from q files. #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b3bad4
fixed epsilon binning out of bounds errors
jessecusack Mar 21, 2026
23d12f7
format
jessecusack Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/glide/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,11 @@ def merge(
dataset_dims = set(ds.dimensions)
ds.close()

if dataset_dims == {"time"}:
if (dataset_dims == {"time"}) | (dataset_dims == {"time", "time_uv"}):
input_file_level = 2
elif dataset_dims == {"profile_id", "z"}:
elif (dataset_dims == {"profile_id", "z"}) | (
dataset_dims == {"profile_id", "z", "time_uv"}
):
input_file_level = 3
else:
raise ValueError(
Expand Down
7 changes: 5 additions & 2 deletions src/glide/process_l3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def bin_q(
ds[v] = (
dims,
np.full_like(ds.conductivity.values, np.nan),
config["variables"][v]["CF"],
config["merged_variables"][v]["CF"],
)
# Dissipation rate is stored in the q file as the log10 of the value.
# Convert it to the actual value.
Expand All @@ -61,7 +61,10 @@ def bin_q(
ds_.profile_time_end.astype("M8[s]"),
)
)
if eds_.e_1.size < 1:
# Filter to valid depths within the bin range (also drops NaN).
in_range = (eds_.depth >= depth_bins[0]) & (eds_.depth <= depth_bins[-1])
eds_ = eds_.sel(time=in_range)
if eds_.time.size < 1:
_log.debug("No epsilon data")
continue
binned = eds_.groupby_bins("depth", depth_bins).mean()
Expand Down
Loading