-
-
Notifications
You must be signed in to change notification settings - Fork 323
Remove unused CaptchaField from Issue model to fix schema mismatch #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi @Nachiket-Roy! This pull request needs a peer review before it can be merged. Please request a review from a team member who is not:
Once a valid peer review is submitted, this check will pass automatically. Thank you! |
WalkthroughThe pull request removes CAPTCHA functionality from the Issue model by deleting the CaptchaField import and removing the captcha field definition from the model class. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Knowledge base: Disabled due to 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Monthly LeaderboardHi @Nachiket-Roy! Here's how you rank for January 2026:
Leaderboard based on contributions in January 2026. Keep up the great work! 🚀 |
Jayant2908
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
S3DFX-CYBER
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch on the schema mismatch, @Nachiket-Roy. Removing dead code definitely keeps the migrations cleaner.
One quick security question: Since we are removing the CaptchaField from the model, have we verified that the frontend form for Issue submission still has adequate rate-limiting or alternative protection against bot-spam? I want to make sure we aren't losing a layer of defense here.
|
@S3DFX-CYBER not sure what you are implying but this removed code is not in use anywhere #5386 (comment) |
Related to : #5386
This PR removes the unused CaptchaField from the Issue model. The field was defined in the model but never added to the database schema via migration, resulting in a model-database mismatch.
Since the field is no longer used anywhere in the codebase, removing it resolves the inconsistency and avoids potential future issues.
Problem Addressed
Why removal is the right fix
Scope
Testing
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.