Fixed some of function does not exist bug for shop 6.2

[nitinsinghoxidesales]

We get below errors in OXID Shop 6.2 related to to this module.

'_deleteModuleEvents' does not exist or is not accessible!
'_deleteModuleVersions' does not exist or is not accessible!
Undefined index: vendor/oxid-community/moduleinternals/Core/ModuleStateFixer.php on line 590

Changes Done:

1. We are validating if methods are exist before running it.
2. Validate isset($onlyInBeforeFix[$core]) before checking with module chain.

[mprokopov]

Might be wrapping calls to _deleteTemplateFiles into the exception handling would be a better fix for that, as checking a method presence violates "tell, don't ask" OOP principle.

[nitinsinghoxidesales]

Might be wrapping calls to _deleteTemplateFiles into the exception handling would be a better fix for that, as checking a method presence violates "tell, don't ask" OOP principle.

Thanks @mprokopov for your feedback.

Actually, function check for example _deleteTemplateFiles only because of backward compatibility. Shop 6.1 and 6.2 having different mechanism.

Ideally we should remove below code for shop 6.2 as it doesn't make sense. We are not reporting it as exception because its actually no error/ issue and it doesn't matter for shop 6.2 but for shop 6.1 function like _deleteTemplateFiles runs and does actions.
$this->output->warning("$sModuleId unregister templates:"); $this->_deleteTemplateFiles($sModuleId); $this->needCacheClear = true;

[alfredbez]

I'm not sure if it makes sense to patch the existing version of module-internals to be compatible with OXID 6.2 since so much has changed especially in the modules area.

I have the feeling that this module is too tightly coupled to the shop-core.

This is not related to your fix, but just my general thoughts on this module and the problems we have with 6.2.