Conversation
Contributor
Author
|
I just saw issue #2 . Does this solve it or is it more subtle and I should undo my edits on |
Collaborator
|
This looks correct, but I don't have the memory of the code flow to be sure. My main recommendation is to test it with your wifi, run a |
NickSwainston
approved these changes
Jan 28, 2025
Contributor
Author
|
Need to add (if not already done), a check for the word "error" in the response (e.g. template_response.text ) could be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No error raising in
list_graphqlmeant that if a Seqera MeerPipe job failed at theOBS_LISTstage, it could be recorded as completed. So I added error raising there.I though I'd add it everywhere else too but not sure if that's going to cause unnecessary/numerous job fails if some errors should stay silent. Can modify if that happens.