Skip to content

Conversation

@veryCrunchy
Copy link
Member

Remove several server API routes for Docker management from the
dashboard app and clean up workspace tsconfig references. Deleted
endpoints:

  • POST /api/docker/status-container (start/stop/restart/kill container)
  • GET /api/docker/list-containers (list and map container info)
  • GET /api/docker/attach-stream (attach to container logs/stream)

Also removed a lingering package reference to the database package from
packages/config/tsconfig.json and commented workspace references in the
root tsconfig.json (and removed the database project reference). These
changes simplify the dashboard server surface and remove unused or
deprecated container control endpoints and stale TypeScript project
references.

Remove several server API routes for Docker management from the
dashboard app and clean up workspace tsconfig references. Deleted
endpoints:
- POST /api/docker/status-container (start/stop/restart/kill container)
- GET /api/docker/list-containers (list and map container info)
- GET /api/docker/attach-stream (attach to container logs/stream)

Also removed a lingering package reference to the database package from
packages/config/tsconfig.json and commented workspace references in the
root tsconfig.json (and removed the database project reference). These
changes simplify the dashboard server surface and remove unused or
deprecated container control endpoints and stale TypeScript project
references.
Copilot AI review requested due to automatic review settings February 1, 2026 06:01
@veryCrunchy veryCrunchy merged commit 627ffbc into main Feb 1, 2026
0 of 2 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes deprecated Docker container management endpoints from the dashboard API and cleans up stale TypeScript project references to a database package. The refactoring aims to simplify the dashboard server surface by eliminating unused container control functionality.

Changes:

  • Removed five Docker API endpoints: status-container, list-containers, attach-stream, inspect-container, and create-container
  • Removed docker-config.ts configuration file and @obiente/docker-engine package dependency
  • Cleaned up TypeScript configuration files to remove database package references

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsconfig.json Removed commented database package path mappings and project reference
packages/config/tsconfig.json Removed database package from path mappings
apps/dashboard/server/docker-config.ts Deleted Docker engine configuration file
apps/dashboard/server/api/docker/status-container.post.ts Deleted endpoint for starting/stopping/restarting/killing containers
apps/dashboard/server/api/docker/list-containers.get.ts Deleted endpoint for listing and mapping container information
apps/dashboard/server/api/docker/inspect-container.get.ts Deleted endpoint for inspecting container details
apps/dashboard/server/api/docker/create-container.post.ts Deleted endpoint for creating new containers
apps/dashboard/server/api/docker/attach-stream.get.ts Deleted endpoint for attaching to container logs via SSE
apps/dashboard/package.json Removed @obiente/docker-engine workspace dependency
Comments suppressed due to low confidence (3)

apps/dashboard/server/api/docker/list-containers.get.ts:1

  • This endpoint is still being used by apps/dashboard/app/pages/logtest.vue at line 43. Removing this endpoint will break the logtest page functionality. The page calls this endpoint in the loadContainers() function to fetch and display available Docker containers. Either the logtest.vue page should be updated or removed, or this endpoint should be kept.
    apps/dashboard/server/api/docker/attach-stream.get.ts:1
  • This endpoint is still being used by apps/dashboard/app/pages/logtest.vue at lines 87-89. Removing this endpoint will break the logtest page functionality. The page calls this endpoint in the startLogStream() function to attach to container logs via Server-Sent Events (SSE). Either the logtest.vue page should be updated or removed, or this endpoint should be kept.
    apps/dashboard/server/api/docker/inspect-container.get.ts:1
  • The PR description lists only three deleted endpoints (status-container, list-containers, attach-stream), but this endpoint is also being deleted without being mentioned in the description. The same applies to create-container.post.ts. Consider updating the PR description to include all deleted endpoints for completeness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants