Add alpha docs and Customer 360 release gate#273
Conversation
|
Claude finished @MacAttak's task —— View job Security Review ResultsI've completed a comprehensive security review of all 51 changed files focusing on the six specified security categories. Here are my findings: ✅ PASS - No Critical or High-Severity Vulnerabilities FoundThe security review found only LOW severity issues and several positive security practices: 🔍 Security FindingsLOW Severity Issues
✅ Security Best Practices Observed
🏆 Notable Security Features
📋 Summary
The codebase demonstrates strong security practices with only minor low-risk issues that pose minimal security threat. The identified issues are more about defense-in-depth improvements rather than exploitable vulnerabilities. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91b2175e8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - "Content-Type: application/json" | ||
| - --data | ||
| - '{"query":"query Customer360Runs { runsOrError(limit: 50) { __typename ... on Runs { results { runId status pipelineName } } } }"}' | ||
| dagster_expected_text: customer-360 |
There was a problem hiding this comment.
Use underscore in Dagster evidence expectation
The release-gate manifest currently sets dagster_expected_text to customer-360, but the configured Dagster check command queries runsOrError { results { pipelineName ... } }, and pipeline/job names in this codebase are normalized with underscores (for example product_name.replace('-', '_') in the Dagster runtime). In a healthy demo run this makes the Dagster evidence check fail even when Customer 360 completed successfully, causing a false negative gate failure.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 861dab9e40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not target_path or Path(target_path).suffix != ".md": | ||
| return None |
There was a problem hiding this comment.
Validate non-Markdown internal links in required docs
The link checker skips any local link whose path doesn't end in .md (Path(target_path).suffix != ".md"), so links like ./architecture/ in required pages are never validated. In this commit mkdocs.yml also sets validation.links.not_found: ignore, which means these skipped links are not caught by MkDocs either; the new docs-validate gate can report success while alpha-critical docs still contain broken internal navigation.
Useful? React with 👍 / 👎.
|
Resolved the security review follow-ups after validating both findings against the changed code.
Local verification after the fix: ShellCheck for |
Summary
Adds the alpha documentation and demo release gate needed before
v0.1.0-alpha.1:demo/customer-360/validation.yamlandmake demo-customer-360-validate.DEVPOD_WORKSPACEor explicitDEVPOD_KUBECONFIG.Validation
Local validation completed before push:
make docs-validatepassed.uv run pytest testing/ci/tests/test_validate_docs_navigation.py testing/ci/tests/test_github_actions_node24_pins.py testing/tests/unit/test_customer360_validator.py testing/tests/unit/test_demo_makefile_kubeconfig.py -qpassed: 40 passed.uv run mypy --strict testing/demo/customer360_validator.py testing/ci/validate_customer_360_demo.py testing/tests/unit/test_customer360_validator.pypassed.make helm-lintpassed.make test-unitpassed: 10035 passed, 1 skipped, 1 xfailed, coverage 87.63%.Release posture
This PR does not make the alpha tag ready by itself. The release remains blocked until GitHub CI, security scans, live Customer 360 validation, manual UI evidence, and DevPod + Hetzner E2E validation are recorded in
docs/validation/2026-04-29-alpha-customer-360-release-validation.md.#263 remains open as post-alpha architecture debt only for the current alpha promise, where Customer 360 includes Iceberg/
floe-iceberg. If the alpha promise changes to support Dagster without Iceberg installed, #263 becomes blocking before tagging.Issues
Resolves #197.
Resolves #271 for normal GitHub Actions; tracks Anthropic Claude workflow checkout-pin rollout separately in #274.
Tracks #263 as known post-alpha architecture debt.