Skip to content

Add more logging around git clone faillure #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rain-on merged 9 commits into from
Jan 6, 2026
Merged

Add more logging around git clone faillure #1700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d5cddc1
Add more logging around git clone faillure
rain-on Dec 30, 2025
ec305da
add more logging - exception type
rain-on Dec 30, 2025
175d6aa
empty work
rain-on Jan 4, 2026
9a713e1
revert empty work
rain-on Jan 4, 2026
1ad771d
add variable to allow full stack trace to be dumped to logs
rain-on Jan 4, 2026
89989fd
fix task log
rain-on Jan 4, 2026
8608dda
minimise change
rain-on Jan 5, 2026
f5c7adc
remove cruft
rain-on Jan 5, 2026
ca014c4
hack the working directory for good or evil
rain-on Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/Build.TestCalamariFlavourProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ partial class Build

DotNetTasks.DotNetTest(settings => settings
.SetProjectFile($"CalamariTests/{testProject}.dll")
.SetProcessWorkingDirectory("CalamariTests")
.SetFilter(CalamariFlavourTestCaseFilter)
.SetLoggers("trx")
.SetProcessExitHandler(
Expand Down
2 changes: 1 addition & 1 deletion source/Calamari/ArgoCD/Conventions/ArgoCDTaskLogExtensionMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static void LogMissingAnnotationsWarning(this ILog log, (ProjectSlug Project, En
{
log.WarnFormat(" - {0}: {1}", ArgoCDConstants.Annotations.OctopusTenantAnnotationKey("<sourcename>".ToApplicationSourceName()), deploymentScope.Tenant);
}
log.WarnFormat("Annotation creation documentation can be found {0}.", log.FormatShortLink("argo-cd-scoping-annotations", "here"));
log.WarnFormat("Annotation creation documentation can be found {0}.", log.FormatShortLink("argo-cd-annotations-docs", "here"));
}

public static void LogApplicationCounts(this ILog log, (ProjectSlug Project, EnvironmentSlug Environment, TenantSlug? Tenant) deploymentScope, ArgoCDApplicationDto[] applications)
Expand Down
4 changes: 3 additions & 1 deletion source/Calamari/ArgoCD/Git/RepositoryFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ RepositoryWrapper CheckoutGitRepository(IGitConnection gitConnection, string che
catch (Exception e)
{
timedOp.Abandon(e);
throw new CommandException($"Failed to clone Git repository at {gitConnection.Url}. Are you sure this is a Git repository?");
log.Error("Cloning repository failed");
log.Verbose(e.PrettyPrint());
throw new CommandException($"Failed to clone Git repository at {gitConnection.Url}. Are you sure this is a Git repository? {e.Message}", e);
}
}

Expand Down