Skip to content

Conversation

@archer-65
Copy link

This should fix cases with helm trying to override volumeName, which is an immutable field.

This should fix cases with helm trying to override volumeName, which is an immutable field.
@archer-65 archer-65 requested a review from a team as a code owner October 24, 2025 13:25
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: dcc2080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2025

CLA assistant check
All committers have signed the CLA.

@liam-mackie
Copy link
Contributor

Hi! First of all, thanks for the PR, we appreciate all contributions!

I was hoping to get some more information on the problem you ran into that prompted this change, as I wouldn't expect that the PVC volumeName would change from the original value unless the user specifically changed .Values.persistence.volumeName. The problem is that this failure mode would still exist with your change included, as we set it to that value if it's set at all, so we'd be in the same position, but also have a lookup that causes problems with people who use ArgoCD to install the chart.

@archer-65
Copy link
Author

Hi!

We ran into this issue because we don’t explicitly set volumeName; instead, we rely on EFS dynamic volume provisioning. During a helmfile sync operation on an existing release, we observed that Helm attempted to reconcile the existing PVC by setting volumeName to an empty value.

The fact lookup would cause problems is related to the the fact lookup is not run during helm template operations, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants