[2022.3][AppSW] Fix incorrect motionVector pass check#30
Open
TrevorDaschOculus wants to merge 1 commit into2022.3/oculus-app-spacewarpfrom
Open
[2022.3][AppSW] Fix incorrect motionVector pass check#30TrevorDaschOculus wants to merge 1 commit into2022.3/oculus-app-spacewarpfrom
TrevorDaschOculus wants to merge 1 commit into2022.3/oculus-app-spacewarpfrom
Conversation
…-1, simply copy the 'hasMotionVectorPass'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Instead of checking whether the motionVectorRenderTarget is equal to -1, simply copy the 'hasMotionVectorPass' from the engine's XRRenderPass.
Testing status
Confirmed that MotionVector pass executes when expected and is skipped when not expected
Comments to reviewers
Notes for the reviewers you have assigned.