Add git_changlog_by_date directive + tests + docs#36
Add git_changlog_by_date directive + tests + docs#36nanuxbe wants to merge 2 commits intoOddBloke:masterfrom
Conversation
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
Hey @nanuxbe, thanks so much for the contribution! Sorry it's taken me such a long time to review it. I've got a couple of comments inline on the tests, but this otherwise looks pretty good.
(I know it's been ages since you submitted this, so let me know if you aren't interested in these changes any more.)
| datetime.now() + timedelta(days=1) | ||
| ).split('.')[0] | ||
| os.environ['GIT_AUTHOR_DATE'] = tomorrow | ||
| os.environ['GIT_COMMITER_DATE'] = tomorrow |
There was a problem hiding this comment.
I suspect the modifying the environment wholesale might cause problems for other tests that run after this one, if they rely on the commit date being today. Could we modify this to restore the environment to its previous state?
| self._set_username('Test User') | ||
|
|
||
|
|
||
| class TestGroupByDate(ChangelogByDateTestCase): |
There was a problem hiding this comment.
These tests look good, but I'd also like to see one for the rebase/cherry-pick case, checking that the ordering is as we expect it to be.
|
Hi @OddBloke , |
2 participants
Hello,
another need I've ran into is being able to group commits by date (in a chronological way). With features like rebase, it often happens that commits are not in a chronological orders. This allows for a "better understanding" of the order in which decisions/changes happened.
This PR introduces the directive git_changelog_by_date which does just that.