Add option to show a grid of banners #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the magic number of ‘8’ icons per row with a variable, allowing it to be modifiable.
This allows it to either be set to `square_icons` for the existing 8x4 grid of square icons, or `banners` for the new 3x4 grid of banners (which have an aspect ratio of 3:1). If not specified, it’ll default to the square icons (the current behaviour).
This adds support for showing a 3x4 grid of banners (at 3:1 aspect ratio), when this grid type is set in the .ini file. To show them at this aspect ratio, it just scales the cubes used for the icons by 3 on the x axis.
This replaces `ASSETS_PER_LINE` with the `columns_per_line` variable, and adds new variables to replace `ASSETS_PER_PAGE` and `ASSETS_INITIAL_COUNT`.
Author
|
While tinkering with this, I had another idea for how this could be laid out – by scaling the banners by 0.75x, it's possible to fit a 4x4 grid on-screen (leaving more vertical space between rows), which might be preferable for those with a lot of games. I'll add this as an extra commit, which can be used by setting |
While tinkering with grids of banners, I had another idea for how to lay it out. By shrinking the grid elements by 0.75x, it’s possible to fit an additional banner per row (leaving more vertical space between rows). This might be preferable for those with larger libraries. This option can be used by setting the `menu_grid_type` .ini setting to `small_banners`.
# Conflicts: # cubeboot/source/main.c # patches/source/grid.c
# Conflicts: # cubeboot/source/main.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to show a 3x4 grid of 3:1 banners in the game selection menu, allowing game banners to be displayed without needing them to be stretched.
This can be configured using a
menu_grid_layout.ini setting; set this tosquare_iconsfor the existing layout, and tobannersfor this new layout. The default issquare_icons(the status quo).