-
Notifications
You must be signed in to change notification settings - Fork 419
docs: tw351-arbchain-stake-validator-config #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anegg0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. Looks good, but of course, this is only an editorial review.
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
...hain/02-configure-your-chain/common-configurations/04-stake-and-validator-configurations.mdx
Outdated
Show resolved
Hide resolved
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…igurations/04-stake-and-validator-configurations.mdx Co-authored-by: Gaël Blanchemain <anegg0@users.noreply.github.com>
…m:OffchainLabs/arbitrum-docs into tw351-arbchain-stake-and-validator-config
- Removed stake with bond (except where referencing code) - used property names with backticks to highlight, i.e., `baseStake` - Minor styling - Added links to the `rollupConfiguDataType.ts`
| assertion | ||
| </a> challenges. Validators post assertions about the chain's state on the parent L2 chain and can <a data-quicklook-from="challenge"> | ||
| challenge | ||
| </a> incorrect assertions. Arbitrum (Orbit) chains can be permissioned, meaning validators must be allowlisted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the allowlisted part it might be worth mentioning that if BoLD protocol is used then allowlisting is not a thing and permissionless validation is allowed.
|
|
||
| ### How to Configure | ||
|
|
||
| - During deployment in the [Arbitrum Orbit deployment portal](https://orbit.arbitrum.io/): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not seen in any docs about using the Arbitrum Orbit website to modify your chain. I could be wrong it but it seems incorrect as the only section where it says build and monitor shows RaaS providers and a link to arb docs. I also dont see a place to link your wallet. So I believe this is a hallucination along with every other mention of configuring your chain using the arbitrum portal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good callout—I believe this was a thing, but isn't available anymore. 👍
|
|
||
| ### Configuration details | ||
|
|
||
| - Specified as a float value (e.g., in `wei` for `ETH`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
floats aren't a thing in EVM/Solidity due to CPUS doing float arithmetic differently. But this might be more of a semantic thing since it may be represented as a float on the frontend and then converted to an int for the transaction call
|
|
||
| - **During deployment**: Set in the `loserStakeEscrow` field of the `RollupCreator` configuration. | ||
| - **Post-deployment**: | ||
| 1. As the chain owner or upgrade executor, call the `Rollup.setLoserStakeEscrow`(address `newEscrow`) function on the [Rollup contract](https://github.com/OffchainLabs/arbitrum-orbit-deployment-ui/blob/e4e82fca2428ad4c8a20ef19b7b958293ffef958/src/types/rollupConfigDataType.ts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a point to fix but a point of reference. This process seems to be what should happen for both during deployment and post deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in the aspect of using the 'rollupCreator' config and using a block explorer like ether scan to find the proper contract and then using some wallet device like metamask as it says to communicate with those smart contracts
No description provided.