-
Notifications
You must be signed in to change notification settings - Fork 156
release: v3.2.0 #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
release: v3.2.0 #395
Conversation
chore: merge develop with 3.1.0 to main
chore: merge develop with v3.1.1 to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This release (v3.2.0) introduces several significant enhancements to the nitro-contracts repository, focusing on improved deployment processes, custom data availability support, and resource management capabilities.
Key changes:
- Added CustomDA proof validation interface and implementation for alternative data availability solutions
- Introduced ResourceConstraintManager for gas pricing constraint management
- Implemented base stake adjustment mechanisms (increase/decrease) with safety checks for permissioned chains
- Migrated to deterministic CREATE2 deployments for all factory contracts
- Enhanced rollup initialization with optional data cost estimation
Reviewed Changes
Copilot reviewed 69 out of 71 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/osp/OneStepProverHostIo.sol | Added CustomDA validator support with certificate validation and preimage reading |
| src/osp/ICustomDAProofValidator.sol | New interface for custom data availability proof validators |
| src/rollup/RollupAdminLogic.sol | Split setBaseStake into increaseBaseStake and decreaseBaseStake with additional safety checks |
| src/rollup/RollupCreator.sol | Added constructor with initial setup and customOsp parameter support |
| src/rollup/BridgeCreator.sol | Removed Ownable inheritance and update functions |
| src/rollup/ValidatorWalletCreator.sol | Simplified to immutable template without owner management |
| src/chain/ResourceConstraintManager.sol | New contract for managing gas pricing constraints with time-based expiry |
| scripts/deploymentUtils.ts | Enhanced with CREATE2 support and consolidated OneStepProof deployment |
| test/foundry/Rollup.t.sol | Updated tests for new base stake adjustment functions |
| test/foundry/OneStepProverHostIo.t.sol | Comprehensive tests for CustomDA proof validation |
Comments suppressed due to low confidence (1)
scripts/deploymentUtils.ts:1
- [nitpick] This complex string manipulation for address extraction should be extracted into a helper function with a descriptive name to improve readability and reusability.
import { ethers } from 'hardhat'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1da79e2 to
f0d4ef1
Compare
* feat: deploy custom da validator * fix: factory should have no custom da
Co-authored-by: gzeon <hng@offchainlabs.com>
What's Changed
setting base to
mainfor review