Skip to content

Conversation

@gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Nov 18, 2025

What's Changed

setting base to main for review

chore: merge develop with 3.1.0 to main
chore: merge develop with v3.1.1 to main
@gzeoneth gzeoneth changed the base branch from develop to main November 18, 2025 09:33
@gzeoneth gzeoneth requested a review from Copilot November 18, 2025 09:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This release (v3.2.0) introduces several significant enhancements to the nitro-contracts repository, focusing on improved deployment processes, custom data availability support, and resource management capabilities.

Key changes:

  • Added CustomDA proof validation interface and implementation for alternative data availability solutions
  • Introduced ResourceConstraintManager for gas pricing constraint management
  • Implemented base stake adjustment mechanisms (increase/decrease) with safety checks for permissioned chains
  • Migrated to deterministic CREATE2 deployments for all factory contracts
  • Enhanced rollup initialization with optional data cost estimation

Reviewed Changes

Copilot reviewed 69 out of 71 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/osp/OneStepProverHostIo.sol Added CustomDA validator support with certificate validation and preimage reading
src/osp/ICustomDAProofValidator.sol New interface for custom data availability proof validators
src/rollup/RollupAdminLogic.sol Split setBaseStake into increaseBaseStake and decreaseBaseStake with additional safety checks
src/rollup/RollupCreator.sol Added constructor with initial setup and customOsp parameter support
src/rollup/BridgeCreator.sol Removed Ownable inheritance and update functions
src/rollup/ValidatorWalletCreator.sol Simplified to immutable template without owner management
src/chain/ResourceConstraintManager.sol New contract for managing gas pricing constraints with time-based expiry
scripts/deploymentUtils.ts Enhanced with CREATE2 support and consolidated OneStepProof deployment
test/foundry/Rollup.t.sol Updated tests for new base stake adjustment functions
test/foundry/OneStepProverHostIo.t.sol Comprehensive tests for CustomDA proof validation
Comments suppressed due to low confidence (1)

scripts/deploymentUtils.ts:1

  • [nitpick] This complex string manipulation for address extraction should be extracted into a helper function with a descriptive name to improve readability and reusability.
import { ethers } from 'hardhat'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzeoneth gzeoneth changed the base branch from main to develop January 7, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants