Fix executeValidatePreimage to match Rust prover validation #398
+73
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Solidity executeValidatePreimage function was missing validations present in the equivalent Rust ValidateCertificate opcode handler. - Add check for preimageType > 255, setting ERRORED status - Add check for preimageType 4-255, returning 0 without memory access - Add ptr validation using isValidLeaf() before memory proof - Reorder operations to validate preimageType before memory access
… of ERRORED When preimageType exceeds 255 (can't fit in u8), the Rust execution code uses the ? operator to propagate an error from step_n(), rather than calling error!() which would set MachineStatus::Errored. The Solidity one-step prover should match this behavior by reverting (proof is invalid) rather than setting ERRORED (valid machine state transition).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solidity executeValidatePreimage function was missing validations present in the equivalent Rust ValidateCertificate opcode handler.