Skip to content

Conversation

@godzillaba
Copy link
Contributor

@godzillaba godzillaba commented Jan 14, 2025

  • versioner script upgrade path
  • upgrade action
  • action tests
  • deployment script
  • execution script
  • readme
  • audit
  • tag patch version Decimals patch version - v2.1.2 nitro-contracts#292
  • replace personal account npm dependency with official one
  • metadata hashes for v2.1.2, only need ERC20Bridge hash
  • deploy actions

@godzillaba godzillaba requested a review from yahgwai January 15, 2025 20:56
@godzillaba
Copy link
Contributor Author

hardhat ERC20Bridge: 122015780c5a69efd79a90adc3c14919c8a776c3acdc3575261bf44f3d54f2b6
forge ERC20Bridge: 1220e960459b981dbc4d07204a7a2305085824f5a8787332d5649a5b64b1c098

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

@godzillaba godzillaba marked this pull request as ready for review February 19, 2025 20:44
@godzillaba godzillaba requested a review from gzeoneth February 21, 2025 17:13
@gzeoneth gzeoneth changed the base branch from bold-upgrade-guide to main February 24, 2025 09:29
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, deploying

@gzeoneth gzeoneth mentioned this pull request Feb 24, 2025
11 tasks
@godzillaba
Copy link
Contributor Author

verified deployments

@godzillaba godzillaba merged commit b9c822d into main Feb 24, 2025
9 checks passed
@godzillaba godzillaba deleted the custom-fee-patch branch February 24, 2025 21:04
zacshowa referenced this pull request in EspressoSystems/orbit-actions Apr 1, 2025
* Add NitroContracts2Point0Point0UpgradeAction

* Add AddWasmCacheManagerAction

* Add deployer script for contracts v2.0.0 action

* Add script which executes the upgrade

* Add script that deploy cache manager action

* Add hashes

* Fix compilation

* Fix script

* Add upgrade action readme

* Update README

* Deploy CacheManager as part of DeployAddWasmCacheManagerActionScript

* Update toml

* Add OZ

* Remove OZ

* Fix TUP deployment

* Fix CI

* Upgrade rollup contracts

* Improve checks

* Improve versioner script

* Update sigs

* Add upgrade action name to print out

* Update versions

* Do on-chain check to see if previous upgrade took place

* Review fixes

* Add action to upgrade token bridge creator to v1.2.2

* Add token bridge 1.2.2 to dependencies

* Add deployer script for token bridge creator upgrade action

* Improve version org

* Update for ci checks

* Bump from v2.0.0 to v2.1.0

* Update yarn.lock

* Add v2.1.0 hashes

* Add action

* Update storage files

* Update sig files

* STorage files

* Update revert message

* Add wasm module root check as prerequisite

* Update supported versions

* Remove unnecessary

* Add FAQ to readme

* Update readme

* Add module root check

* Update readme

* Add instructions how to perform action to add cache manager

* Typos

* Update relative paths

* feat: EnableFastConfirmAction (#18)

* feat: EnableFastConfirmAction

* chore: EnableFastConfirmAction env example

* docs: EnableFastConfirmAction

* docs: more about EnableFastConfirmAction

* refactor: move checks to constructor

* Use immutable

* New action sigs

* New action storage file

* Update storage files

* Storage file

* Add readme

* Rename file

* Readme

* Add note on option out of stylus

* Update deployment script to execute the upgrade

* Update readme

* Add env templates

* Add comment

* Update instruction to support contracts upgrade, but not ArbOS

* Update hash

* Add addresses

* Update address

* Update readme

Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>

* Use encodeCall

Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>

* Add note on option out of stylus

* Update instruction to support contracts upgrade, but not ArbOS

* Update hash

* Add addresses

* Update address

* Format

* Update readme

* Fix typo in docs

* Update README.md

Co-authored-by: Derek <103802618+leeederek@users.noreply.github.com>

* Update README.md

Co-authored-by: Derek <103802618+leeederek@users.noreply.github.com>

* fix: fast confirm safe customizable salt (#19)

* fix: fast confirm safe customizable salt

* chore: update sigs

* docs: salt

* chore: update testnet deployments

* Minor improvements and output files

* feat: custom threshold in EnableFastConfirmAction (#20)

* feat: custom threshold in EnableFastConfirmAction

* docs: update readme

* chore: update sigs

* fix: lint

* fix: arbsys mock for deployment

* chore: 2.1.0 upgrade action deployments

* chore: fast confirm action deployments

* feat: use inbox instead of rollup address

* docs: add env instruction

* docs: update orbit actions readme for arbos31

This PR:
- fixes a broken link for the stylus cache manager
- adds hyperlinks to arbos31 and arbos20 specific documentation
- adds hyperlinks to the canonical docs.arbitrum.io how-to guides for upgrading arbos on orbit chains
- adds arbos31 specific instructions under the "common upgrade paths" section 

Do not merge until Nitro 3.1.1 is GA'ed.

* bump to nitro v3.1.2

* docs: TARGET_WASM_MODULE_ROOT

* Use arbos v32 wasm root

* fix 1 more mention of arbos31

* Update file path and some comments

* update min nitro version for arbos32 (#34)

* update min nitro version for arbos32

* fix: ci storage test

---------

Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>

* v2.1.2 decimals patch version (#36)

* chore: update v3.0.0 meta

* feat: add any

* docs: comments

* chore: add rei hashes

* fix: type

* feat: check fee token

* feat: v3 upgrade check

* docs: bold upgrade draft

* add version path

* fmt

* add action

* fix

* snapshot

* add tests

* readme

* deployment script

* execution script

* format

* Revert "format"

This reverts commit 6fc72a0.

* reformat

* tight broadcast

* Update README.md

* misc

* fix

* postUpgradeInit

* main readme

* Update scripts/foundry/contract-upgrades/3.0.0/README.md

Co-authored-by: gzeon <hng@offchainlabs.com>

* readme tweak

* note

* Update scripts/foundry/contract-upgrades/3.0.0/README.md

* add 2.1.2 to 3.0.0 allowed versions

* typo

* fix: disable custom fee token chain support for v3 for now

* replace npm package

* metadata hashes

* chore: no bold upgrade

* chore: also remove v3 hashes

* ci: use foundry stable

* fix: lint

* test: remove pretty flag from inspect

* test: commit new format

* chore: deployments

---------

Co-authored-by: gzeon <im@gzeon.dev>
Co-authored-by: gzeon <hng@offchainlabs.com>

* 7702 patch - v2.1.3 (#38)

* chore: update v3.0.0 meta

* feat: add any

* docs: comments

* chore: add rei hashes

* fix: type

* feat: check fee token

* feat: v3 upgrade check

* docs: bold upgrade draft

* add version path

* fmt

* add action

* fix

* snapshot

* add tests

* readme

* deployment script

* execution script

* format

* Revert "format"

This reverts commit 6fc72a0.

* reformat

* tight broadcast

* Update README.md

* misc

* fix

* postUpgradeInit

* main readme

* Update scripts/foundry/contract-upgrades/3.0.0/README.md

Co-authored-by: gzeon <hng@offchainlabs.com>

* readme tweak

* note

* Update scripts/foundry/contract-upgrades/3.0.0/README.md

* add 2.1.2 to 3.0.0 allowed versions

* 2.1.3 upgrade path

* typo

* 2.1.3 action + script

* fix path

* 7702 patch readme

* remove todo

* fix

* fix with updated foundry

* fix: disable custom fee token chain support for v3 for now

* replace npm package

* metadata hashes

* NitroContract 2.1.3 Upgrade Action deployed (#40)

* NitroContract 2.1.3 Upgrade Action deployed

* simplified deployment, fixed ETH sequencer inbox bug

* lint

* Update scripts/foundry/contract-upgrades/2.1.3/.env.sample

Co-authored-by: gzeon <h@arry.io>

---------

Co-authored-by: gzeon <h@arry.io>

* todo deployment

* npm package

* metadata hashes

* remove cancun

* some test cases

* check version test

* gas snapshot

* fmt

* chore: no bold upgrade

* chore: also remove v3 hashes

* ci: use foundry stable

* fix: lint

* test: remove pretty flag from inspect

* test: commit new format

* chore: deployments

* fix: new inspect

* feat: validate MAX_DATA_SIZE

* chore: reduce diff

* fix: interface

* fix: validate inbox is inbox

* chore: update gas snapshot

* finish merge

* deployments

* holesky deployment - not verified on etherscan

* Revert "holesky deployment - not verified on etherscan"

This reverts commit 5ccaff8.

* holesky deployment - not verified on etherscan (correct maxDataSize)

* fix: version conditions

* fix: same metadatahash

* feat: throw when multiple upgrade path found

---------

Co-authored-by: gzeon <im@gzeon.dev>
Co-authored-by: gzeon <hng@offchainlabs.com>
Co-authored-by: tadad <43223192+tadad@users.noreply.github.com>
Co-authored-by: gzeon <h@arry.io>

* update readme (#41)

* add note to 2.1.3 guide about 2.1.2 (#42)

* add note to 2.1.3 guide about 2.1.2

* mention versioner

* hotfix: no need to upgrade bridge for v2 bridges (#43)

* fix: no need to upgrade bridge for v2 bridges

* format: eslint

* hotfix: non fee token chain detection (#49)

* chore: update deployment addresses (#50)

* Fix compilation and unit tests

* update nitro-contracts sub-module

* remove incorrect version of arbitrum-sdk

* fix errors in json file causing build to fail.

* Add .gitignore rule for local deployment files.

* forge install: arbitrum-sdk

v3.3.0

* update lint workflow to skip lint temporarily

* Add forge fmt check to the lint CI

---------

Co-authored-by: Goran Vladika <goran.vladika@gmail.com>
Co-authored-by: gzeon <hng@offchainlabs.com>
Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
Co-authored-by: Derek <103802618+leeederek@users.noreply.github.com>
Co-authored-by: gzeon <im@gzeon.dev>
Co-authored-by: tadad <43223192+tadad@users.noreply.github.com>
Co-authored-by: gzeon <h@arry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants