Fix for isAddin returning true while in browser

[YannickRe]

This fixes #133 :

In a browser the Utilities.isAddin check return true, even when using it outside of Office. This results in the helpers trying to use the Dialog framework to open an authentication window instead of a normal browser popup.

Problematic code:

office-js-helpers/src/helpers/utilities.ts

Line 180 in a7b0282

return Utilities.host !== HostType.WEB;

When used in the browser, the host property is undefined. This doesn't equal WEB and therefor it is considered being in an AddIn.

Not sure who owns this anymore, so I'm tagging all: @casieber, @Zlatkovsky, @sumurthy & @LouMM

[Zlatkovsky]

FWIW, I think the bigger issue is that Utilities.host returns undefined. This must be a regression (relative to the "@microsoft/office-js-helpers": "0.7.4" that Script Lab uses).

I remember running into something similar with Script Lab, hence we just stayed on 0.7.4. It would be good to diff it to see what the real culprit is.

Let me see if I can identify the issue later today.

[Zlatkovsky]

FYI, I just submitted #135
I would recommend that as a fix

[Zlatkovsky]

FYI, I just submitted #135.

I would recommend that as a better fix, in that it solves this issue, and also the Utilities.host/Utilities.platform APIs. At which point, this PR is no longer needed/relevant.

That said, @YannickRe , thanks for bringing this up to our attention, and prompting me to look into the underlying issue.

[Zlatkovsky]

FYI, I just submitted #135
I would recommend that as a fix

[YannickRe]

#135 is a better fix, closing this one!