Improve devcontainer script #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devcontainer configuration might be saved on .devcontainer folder or .devcontainer.json. This commit add the missing support for .devcontainer.json file.
vscode mounts the entire project (where .git is located) on /workspace. This commit changes the script behavior to find the .git folder, mount this bind and use the current workspace inside the docker just like vscode.
Avoid docker build output buy using the debug function. The output will be displayed if the flag VERBOSE is enabled.
Include support for POST_CREATE_COMMAND and only execute these type of command if the docker file has changed and the image has to be built again.
This initialization script were not working correctly on mcr.microsoft.com/vscode/devcontainers/base:0-ubuntu-20.04 image. The commit avoid this unecessary code as the microsoft image already has the same user id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I noticed that you have a PR unmerged here BorisWilhelms#1 . As I also have updated and improved the script (I think some of the fixes were equal), I updated yours so we can keep an updated version.
Would you like to review it?
[EDIT]
I'm sorry I opened the PR using the wrong account.
It was supposed to be opened by @inm-certi