This repository was archived by the owner on Jan 16, 2021. It is now read-only.
Mybind str fix#85
Open
till-varoquaux wants to merge 3 commits intoOkCupid:masterfrom
till-varoquaux:mybind_str_fix
Open
Mybind str fix#85till-varoquaux wants to merge 3 commits intoOkCupid:masterfrom till-varoquaux:mybind_str_fix
till-varoquaux wants to merge 3 commits intoOkCupid:masterfrom
till-varoquaux:mybind_str_fix
Conversation
Contributor
|
This needs a version bump, but otherwise looks good to me |
Contributor
Author
|
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a dangling pointer issue we had in production and remove binary gender (?!).