Add Spotify block#20
Open
mattmahn wants to merge 5 commits intoOkayDave:developfrom
mattmahn:feature/spotify-block
Open
Add Spotify block#20mattmahn wants to merge 5 commits intoOkayDave:developfrom mattmahn:feature/spotify-block
mattmahn wants to merge 5 commits intoOkayDave:developfrom
mattmahn:feature/spotify-block
Conversation
Author
|
It appears that the Travis build is failing because it cannot connect to the Docker container's D-Bus. This is a known issue: moby/moby#7459, systemd/systemd#589. To get around this, we could use an environment variable to detect whether or not it is being tested in a Docker container, then simply not execute that code that deals with the D-Bus (its only in Barr::Blocks::Spotify#initialize). Thoughts? |
Owner
|
Thanks for this @mattmahn. this looks great. For the test, I'd prefer the DBus connection to be mocked/stubbed rather than it have different behaviours for different environments. It'll keep the tests fast and consistent this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add support for using Spotify as a music player. It works exactly the same as the Rythmbox block.
Since I am not currently using i3/lemonbar, I have not been able to test how well it actually integrates with those. However, I have tested all the other D-Bus and Spotify functionality. The only thing that I think could be a problem is the button controls; those
dbus-sendcommands print to stdout, so I'm not sure if that will break lemonbar or i3. When I removed the--print-replyoption, then Spotify would not do what it was supposed to do (i.e. play/pause, etc). I assume that if printing to stdout is a problem,&>/dev/nullcould simply be tacked onto the end of the command.Tested with:
P.S. I added
vendor/bundleto the .gitignore, so people can keep their development and system gem environments separated.