Skip to content

fix: inferno scene vertical offset#298

Open
cboar wants to merge 1 commit intoOldSchoolSDK:betafrom
cboar:fix/scene-offset
Open

fix: inferno scene vertical offset#298
cboar wants to merge 1 commit intoOldSchoolSDK:betafrom
cboar:fix/scene-offset

Conversation

@cboar
Copy link
Copy Markdown
Contributor

@cboar cboar commented Oct 26, 2025

verticaloffset

May need height adjustment for player as well?

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 26, 2025

Deploy Preview for inferno-trainer ready!

Name Link
🔨 Latest commit e3cc442
🔍 Latest deploy log https://app.netlify.com/projects/inferno-trainer/deploys/68fe9bd6d7f3ed0008ad07f1
😎 Deploy Preview https://deploy-preview-298--inferno-trainer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dereklopes
Copy link
Copy Markdown
Contributor

Honestly, this doesn't seem like an improvement. The character's shoes are sinking into the floor. Is that what you meant by "may need height adjustment for player as well?"

What is this trying to accomplish?

@cboar
Copy link
Copy Markdown
Contributor Author

cboar commented Nov 4, 2025

The tile markers render floating above the scene, suggesting the vertical offset is set incorrectly.
To fix the player height, we should be able to pass the option { verticalOffset: -0.4525 } here: https://github.com/OldSchoolSDK/osrs-sdk/blob/main/src/sdk/Player.ts#L973

@dereklopes
Copy link
Copy Markdown
Contributor

I see, can the tile markers vertical offset be changed? How do the mobs look?

@Supalosa
Copy link
Copy Markdown
Collaborator

Any consensus here? (Sorry for delay, just finding some time now to maintain the sim)

@dereklopes
Copy link
Copy Markdown
Contributor

My questions weren't answered so I don't think there's consensus. Moving everything to fix one thing doesn't seem like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants