Open
Conversation
SDL changes the current context for the destruction of the Splash Window on CloseSplash and sets it to NULL instead of restoring it on Linux, as of SDL2 0.18.2. This will lead subsequent GL calls to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the problems I encountered while building the driver for Linux.
Not mentioned were the missing defines for "TRUE" and "FALSE", which I included below the Win32 ifdef at the beginning of XOpenGL.h
I'm not sure if that's a good place or if the BOOLS should be migrated to bools instead of UBOOL considering they don't seem to be interfacing with the rest of the engine.