ready for merge #351
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,31 @@ | ||
| import { Injectable, CanActivate, ExecutionContext } from '@nestjs/common'; | ||
| import { Reflector } from '@nestjs/core'; | ||
| import { InjectRepository } from '@nestjs/typeorm'; | ||
| import { Repository } from 'typeorm'; | ||
| import { User, UserRole } from '../../users/entities/user.entity'; | ||
|
|
||
| @Injectable() | ||
| export class RolesGuard implements CanActivate { | ||
| constructor( | ||
| private reflector: Reflector, | ||
| @InjectRepository(User) private readonly userRepository: Repository<User>, | ||
| ) {} | ||
|
Comment on lines
+9
to
+12
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "RolesGuard references in modules:"
rg -n -C2 '\bRolesGuard\b' backend/src --glob '**/*.module.ts' || true
echo
echo "RolesGuard use sites:"
rg -n -C2 '@UseGuards\([^)]*\bRolesGuard\b' backend/src --type=ts || true
echo
echo "AuthModule wiring:"
sed -n '1,200p' backend/src/auth/auth.module.tsRepository: OlufunbiIK/tip-tune Length of output: 6982 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Finding RolesGuard file ==="
fd -type f -name '*roles.guard*' backend/src
echo
echo "=== RolesGuard implementation ==="
cat -n backend/src/auth/guards/roles.guard.ts
echo
echo "=== Checking if RolesGuard is exported from any index/barrel file ==="
rg -n 'RolesGuard' backend/src --glob '**/*index*' || true
echo
echo "=== Checking if RolesGuard appears in any .module.ts ==="
rg -n 'RolesGuard' backend/src --glob '**/*.module.ts' || true
echo
echo "=== Checking RolesGuard in auth.module.ts (full file) ==="
wc -l backend/src/auth/auth.module.tsRepository: OlufunbiIK/tip-tune Length of output: 282 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Finding RolesGuard file ==="
find backend/src -name '*roles.guard*'
echo
echo "=== RolesGuard implementation ==="
cat -n backend/src/auth/guards/roles.guard.ts
echo
echo "=== Checking all .module.ts files for RolesGuard ==="
rg 'RolesGuard' backend/src --type ts -l
echo
echo "=== Full AuthModule file ==="
cat -n backend/src/auth/auth.module.tsRepository: OlufunbiIK/tip-tune Length of output: 3269 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Checking app.module.ts ==="
find backend/src -name 'app.module.ts' -exec cat -n {} \;
echo
echo "=== Searching for RolesGuard in any import/provider context ==="
rg -B3 -A3 'RolesGuard' backend/src --type ts --glob '**/*.ts' | grep -E '(providers|imports|@Module)' || trueRepository: OlufunbiIK/tip-tune Length of output: 6788
To fix, add `@Module`({
imports: [TypeOrmModule.forFeature([User]), ...],
providers: [AuthService, WalletStrategy, JwtAuthGuard, RolesGuard],
exports: [AuthService, JwtAuthGuard, WalletStrategy, RolesGuard],
})
export class AuthModule {}Then import AuthModule into any module that uses 🤖 Prompt for AI Agents |
||
|
|
||
| async canActivate(context: ExecutionContext): Promise<boolean> { | ||
| const roles = this.reflector.get<UserRole[]>('roles', context.getHandler()); | ||
| if (!roles) { | ||
| return true; | ||
| } | ||
| const request = context.switchToHttp().getRequest(); | ||
| const principal = request.user as { userId?: string } | undefined; | ||
| if (!principal?.userId) return false; | ||
|
|
||
| const user = await this.userRepository.findOne({ | ||
| where: { id: principal.userId }, | ||
| select: ['id', 'role'], | ||
| }); | ||
| if (!user) return false; | ||
|
|
||
| return roles.includes(user.role); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid logging raw
userIdvalues on authorization failures.These warning paths persist stable user identifiers in auth logs. That is unnecessary for denial auditing and creates a privacy/compliance risk. Prefer a request/correlation ID, or redact/hash the principal before logging.
🛠️ Minimal fix
Also applies to: 58-60
🤖 Prompt for AI Agents