chore: hardening baseline before Dependabot remediation#226
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds pnpm enforcement and overrides, switches CI/build to pnpm & Node 22, adds a pnpm dependency-audit workflow that fails on moderate+ findings and posts a PR comment, and introduces local Claude configuration and related metadata files. Most other edits are documentation markdown formatting. (≤50 words) Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant PR as "Pull Request / Manual Trigger"
participant GHA as "GitHub Actions"
participant Runner as "Ubuntu Runner"
participant Repo as "Repository (checkout)"
participant Node as "Node 22"
participant PNPM as "pnpm"
participant Audit as "pnpm-audit"
PR->>GHA: open PR / dispatch
GHA->>Runner: start job (build / audit)
Runner->>Repo: checkout code
Runner->>Node: setup Node 22
Runner->>PNPM: pnpm/action-setup
Runner->>Repo: pnpm install --frozen-lockfile
alt audit job
Runner->>Audit: run pnpm-audit (level: moderate, fails:true)
Audit-->>GHA: emit results / comment via GITHUB_TOKEN
else build job
Runner->>Repo: pnpm run build / pnpm run lint:check
Runner-->>GHA: report status
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
CLAUDE.md (1)
1-3: Consider adding documentation to explain the purpose of this configuration.The file contains minimal content with no explanation of what Claude Code Configuration is or how it should be used. Adding a brief description would improve maintainability.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CLAUDE.md` around lines 1 - 3, The CLAUDE.md currently only has the header "Claude Code Configuration" and a pointer to "@AGENTS.md" with no explanation; add a short paragraph under the "Claude Code Configuration" heading that explains the purpose of this configuration (what Claude is used for in the repo), when and how to enable/use it, any required environment variables or steps, and reference/link to AGENTS.md for agent-specific details; ensure the description includes actionable notes (e.g., sample config keys or file locations) so readers understand how to apply the Claude configuration.package.json (1)
99-102: Remove the embedded quotes from the scoped selectors.The keys on Lines 99-102 include literal single quotes inside the selector string. pnpm's override examples use raw selectors like
bar@^2.1.0andqar@1>zoo, so these entries are unlikely to match anything as written. Remove the inner quotes or delete the redundant selectors. (pnpm.io)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 99 - 102, The override keys contain literal single quotes around scoped selectors (e.g., "'@babel/helpers@<7.26.10'", "'@babel/runtime-corejs3@<7.26.10'", "'@babel/runtime@<7.26.10'", "'@babel/traverse@<7.23.2'") which prevents pnpm from matching them; remove the inner single quotes so the selectors are raw (e.g., `@babel/helpers`@<7.26.10) or delete any redundant selectors if not needed, updating the keys for `@babel/helpers`, `@babel/runtime-corejs3`, `@babel/runtime` and `@babel/traverse` in package.json accordingly..github/workflows/ci.yml (1)
18-22: Keep the Node runtime consistent across workflows.
build.ymlstill runs Node 18, while this new CI job runs Node 22. For a baseline PR whose goal is clean CI comparison, that makes any install/build delta harder to attribute to dependency changes alone. Consider driving all workflows from one shared version or matrix entry.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 18 - 22, The CI job's "Setup Node.js" step is using node-version: 22 which diverges from build.yml's Node 18; update the workflow to use a single shared Node runtime (e.g., a repository-wide NODE_VERSION variable or a shared workflow/matrix entry) so all workflows (including the "Setup Node.js" step in this CI job and the setup in build.yml) reference the same version; modify the node-version value in the "Setup Node.js" step (and any other setup-node usages) to read from that shared NODE_VERSION to keep runtimes consistent across workflows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/settings.local.json:
- Around line 1-9: Update the permissions entry that currently allows "Bash(yarn
outdated:*)" to the new package manager by changing it to "Bash(pnpm
outdated:*)" (i.e., locate the "permissions" -> "allow" array and replace the
"yarn outdated" command token with the equivalent "pnpm outdated" token so the
permitted command matches the PR's migration from yarn to pnpm).
In @.github/workflows/audit.yml:
- Around line 15-30: Replace the floating action refs with full commit SHA pins
for each action used in the workflow: actions/checkout, actions/setup-node,
pnpm/action-setup, and JamesRobertWiseman/pnpm-audit; update their uses entries
to the corresponding full-length commit SHAs (e.g., actions/checkout@<fullSHA>)
and optionally add a trailing comment indicating the human-friendly tag (e.g., #
v4.1.7) for future reference to ensure immutability and mitigate supply-chain
risk.
In @.github/workflows/build.yml:
- Around line 21-27: The workflow calls pnpm (steps with "pnpm install
--frozen-lockfile" and "pnpm build") but never installs/activates pnpm; add a
step using pnpm/action-setup@v5 before these steps (preserving the existing
cache: 'pnpm') so a pinned, compatible pnpm binary is available for the "Install
dependencies" and "Build project" steps; ensure the setup step runs on the same
job and precedes the pnpm commands.
In `@package.json`:
- Around line 61-98: Dependencies currently use open-ended lower-bound selectors
like "express": ">=4.19.2" and others (e.g., "webpack", "axios",
"@babel/helpers") which can unintentionally upgrade to new major versions;
change each to either a bounded range that restricts to the current major (e.g.,
express@>=4.0.0 <5.0.0: "4.19.2" or equivalent range) or to an exact pinned
version (e.g., "express": "4.19.2"), and also remove literal single quotes
around scoped selectors (fix entries like "'@babel/helpers@<7.26.10'" to
"@babel/helpers@<7.26.10") so the JSON keys are valid and pnpm can parse them.
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 18-22: The CI job's "Setup Node.js" step is using node-version: 22
which diverges from build.yml's Node 18; update the workflow to use a single
shared Node runtime (e.g., a repository-wide NODE_VERSION variable or a shared
workflow/matrix entry) so all workflows (including the "Setup Node.js" step in
this CI job and the setup in build.yml) reference the same version; modify the
node-version value in the "Setup Node.js" step (and any other setup-node usages)
to read from that shared NODE_VERSION to keep runtimes consistent across
workflows.
In `@CLAUDE.md`:
- Around line 1-3: The CLAUDE.md currently only has the header "Claude Code
Configuration" and a pointer to "@AGENTS.md" with no explanation; add a short
paragraph under the "Claude Code Configuration" heading that explains the
purpose of this configuration (what Claude is used for in the repo), when and
how to enable/use it, any required environment variables or steps, and
reference/link to AGENTS.md for agent-specific details; ensure the description
includes actionable notes (e.g., sample config keys or file locations) so
readers understand how to apply the Claude configuration.
In `@package.json`:
- Around line 99-102: The override keys contain literal single quotes around
scoped selectors (e.g., "'@babel/helpers@<7.26.10'",
"'@babel/runtime-corejs3@<7.26.10'", "'@babel/runtime@<7.26.10'",
"'@babel/traverse@<7.23.2'") which prevents pnpm from matching them; remove the
inner single quotes so the selectors are raw (e.g., `@babel/helpers`@<7.26.10) or
delete any redundant selectors if not needed, updating the keys for
`@babel/helpers`, `@babel/runtime-corejs3`, `@babel/runtime` and `@babel/traverse` in
package.json accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2ebcc04a-9819-4cfd-92f4-d70ebe6f05a5
⛔ Files ignored due to path filters (2)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (7)
.claude/settings.local.json.github/workflows/audit.yml.github/workflows/build.yml.github/workflows/ci.yml.npmrcCLAUDE.mdpackage.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 52-58: The "engines" entries for "npm" and "yarn" use non-semver
values ("use-pnpm") which can break tools when engine-strict is enabled; update
package.json by either removing the "npm" and "yarn" keys from the "engines"
object or replace their values with a clearly impossible but safe placeholder
(e.g., "please-use-pnpm") so tooling errors are clearer, leaving "node" and
"pnpm" and the existing "packageManager": "pnpm@10.33.0" intact; target the
"engines" object in package.json to make this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 18e15a02-6063-4a00-bd4a-074198735949
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
.github/workflows/build.ymlpackage.json
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build.yml
Comment on lines
52
to
+58
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=18", | ||
| "pnpm": "10.33.0", | ||
| "npm": "use-pnpm", | ||
| "yarn": "use-pnpm" | ||
| }, | ||
| "packageManager": "pnpm@10.33.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify pnpm version 10.33.0 exists on npm registry
echo "Checking if pnpm@10.33.0 exists..."
npm view pnpm@10.33.0 version 2>/dev/null && echo "✓ Version exists" || echo "✗ Version not found"
echo ""
echo "Latest pnpm versions:"
npm view pnpm versions --json 2>/dev/null | python3 -c "
import json, sys
versions = json.load(sys.stdin)
v10 = [v for v in versions if v.startswith('10.')]
print('10.x versions (last 5):', v10[-5:] if v10 else 'None')
"Repository: OlympusDAO/olympus-docs
Length of output: 229
Replace non-standard engine values with valid semver or remove them.
Setting "npm": "use-pnpm" and "yarn": "use-pnpm" are not valid semver ranges. With engine-strict=true in .npmrc, these will produce confusing error messages. Consider using a clearly impossible version like "please-use-pnpm" or removing these fields entirely since the preinstall hook already enforces pnpm.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` around lines 52 - 58, The "engines" entries for "npm" and
"yarn" use non-semver values ("use-pnpm") which can break tools when
engine-strict is enabled; update package.json by either removing the "npm" and
"yarn" keys from the "engines" object or replace their values with a clearly
impossible but safe placeholder (e.g., "please-use-pnpm") so tooling errors are
clearer, leaving "node" and "pnpm" and the existing "packageManager":
"pnpm@10.33.0" intact; target the "engines" object in package.json to make this
change.
There was a problem hiding this comment.
♻️ Duplicate comments (2)
package.json (2)
61-97:⚠️ Potential issue | 🟠 MajorPrefer bounded (or exact) versions for top-level
pnpm.overrides.Using open-ended
>=specs here can silently pull new major versions on future lockfile refreshes.🔧 Example pattern
- "express": ">=4.19.2", - "webpack": ">=5.94.0", - "axios": ">=0.30.3", + "express": ">=4.19.2 <5.0.0", + "webpack": ">=5.94.0 <6.0.0", + "axios": ">=0.30.3 <1.0.0",#!/bin/bash # List top-level overrides using open-ended lower bounds. jq -r ' .pnpm.overrides | to_entries[] | select((.value|type)=="string" and (.value|startswith(">="))) | "\(.key): \(.value)" ' package.json🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 61 - 97, The pnpm.overrides entries currently use open-ended ">=..." specs which can pull unintended major upgrades; update each top-level override in package.json (the pnpm.overrides map) to use either exact versions (e.g., "1.2.3") or bounded ranges (e.g., "^1.2.3" or "<2.0.0") instead of ">=..." for packages like "axios", "webpack", "lodash", "yaml", "ws", etc.; ensure every string-valued override that begins with ">=" is replaced with a fixed or upper-bounded semver range and run a lockfile refresh to verify the resolved versions.
98-101:⚠️ Potential issue | 🟠 MajorRemove literal apostrophes from override selector keys.
These selector keys include
'as literal characters, so they may not match the intended packages.🔧 Proposed fix
- "'@babel/helpers@<7.26.10'": ">=7.26.10", - "'@babel/runtime-corejs3@<7.26.10'": ">=7.26.10", - "'@babel/runtime@<7.26.10'": ">=7.26.10", - "'@babel/traverse@<7.23.2'": ">=7.23.2", + "@babel/helpers@<7.26.10": ">=7.26.10", + "@babel/runtime-corejs3@<7.26.10": ">=7.26.10", + "@babel/runtime@<7.26.10": ">=7.26.10", + "@babel/traverse@<7.23.2": ">=7.23.2",#!/bin/bash # Verify override keys that contain literal apostrophes. jq -r '.pnpm.overrides | keys[]' package.json | rg -n "^[']|[']$"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 98 - 101, The pnpm.overrides keys contain literal single-quote characters (e.g. "'@babel/helpers@<7.26.10'") which prevents matching the intended package selectors; open package.json, locate the pnpm.overrides object and remove the surrounding single quotes from those keys (e.g. change "'@babel/helpers@<7.26.10'" to "@babel/helpers@<7.26.10", same for "'@babel/runtime-corejs3@<7.26.10'", "'@babel/runtime@<7.26.10'", "'@babel/traverse@<7.23.2'"), save and re-run whatever verification script you use (the provided jq check) to ensure no keys start or end with an apostrophe.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@package.json`:
- Around line 61-97: The pnpm.overrides entries currently use open-ended ">=..."
specs which can pull unintended major upgrades; update each top-level override
in package.json (the pnpm.overrides map) to use either exact versions (e.g.,
"1.2.3") or bounded ranges (e.g., "^1.2.3" or "<2.0.0") instead of ">=..." for
packages like "axios", "webpack", "lodash", "yaml", "ws", etc.; ensure every
string-valued override that begins with ">=" is replaced with a fixed or
upper-bounded semver range and run a lockfile refresh to verify the resolved
versions.
- Around line 98-101: The pnpm.overrides keys contain literal single-quote
characters (e.g. "'@babel/helpers@<7.26.10'") which prevents matching the
intended package selectors; open package.json, locate the pnpm.overrides object
and remove the surrounding single quotes from those keys (e.g. change
"'@babel/helpers@<7.26.10'" to "@babel/helpers@<7.26.10", same for
"'@babel/runtime-corejs3@<7.26.10'", "'@babel/runtime@<7.26.10'",
"'@babel/traverse@<7.23.2'"), save and re-run whatever verification script you
use (the provided jq check) to ensure no keys start or end with an apostrophe.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
package.json (2)
61-101:⚠️ Potential issue | 🟠 MajorOpen-ended override floors can still drift into incompatible majors.
Using values like
">=..."for broad keys (for example Line 70, Line 74, Line 97, Line 100) allows future lock refreshes to jump beyond currently tested major lines.Suggested direction
- "express": ">=4.19.2", - "webpack": ">=5.94.0", - "ws": ">=8.17.1", + "express": "4.21.2", + "webpack": "5.104.1", + "ws": "8.18.3",Or use bounded selectors (
>=x <nextMajor) when exact pinning is too strict.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 61 - 101, The dependency ranges using open-ended selectors like ">=0.30.3" (e.g., "axios", "lodash", "webpack", "yaml" and others in this block) can allow upgrades into new major versions; change these to bounded ranges that prevent unintended major bumps (for example ">=X.Y.Z <(X+1).0.0") or use caret pins compatible with your stability policy so lockfile refreshes cannot jump majors; update each affected entry (e.g., "@babel/helpers", "axios", "lodash", "webpack", "yaml", etc.) to the appropriate ">=current <nextMajor" range.
55-56:⚠️ Potential issue | 🟡 Minor
engines.npm/engines.yarnare still non-semver values.Line 55 and Line 56 use
"use-pnpm", which is not a semver range and can produce confusing engine-strict behavior in tooling.Suggested change
"engines": { "node": ">=18", "pnpm": "10.33.0", - "npm": "use-pnpm", - "yarn": "use-pnpm" + "npm": ">=0.0.0-0", + "yarn": ">=0.0.0-0" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 55 - 56, The engines.npm and engines.yarn fields currently use the non-semver value "use-pnpm", which is invalid for engine checks; replace those values with valid semver ranges (e.g., ">=8" or a specific allowed range) or remove the engines.npm and engines.yarn keys entirely and rely on the packageManager field to indicate pnpm; update the package.json engines.npm and engines.yarn entries accordingly so they contain proper semver ranges (or delete them) to avoid tooling confusion.
🧹 Nitpick comments (1)
package.json (1)
58-58: PinningpackageManagershould be mirrored in CI setup.Line 58 pins
pnpm@10.33.0, but.github/workflows/ci.ymlcurrently installs pnpm without an explicit version (pnpm/action-setup@v5only). Pinning both avoids version drift between local and CI.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 58, package.json pins "packageManager": "pnpm@10.33.0" but the CI uses the pnpm setup action without a matching pinned version; update the CI pnpm setup step (the pnpm/action-setup@v5 usage) to explicitly install pnpm@10.33.0 (or reference the same "pnpm@10.33.0" string) so the CI runner uses the exact same pnpm version as package.json to avoid drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 88: Remove the global override entry forcing "path-to-regexp": "1.9.0"
from package.json (the top-level overrides object), leaving the existing scoped
override selectors (e.g., "path-to-regexp@>=0.2.0 <1.9.0": ">=1.9.0" and
"react-router@5.3.3>path-to-regexp") intact so consumers can resolve appropriate
versions without being globally pinned; in short, delete the standalone
"path-to-regexp": "1.9.0" override key and keep only the scoped selectors.
---
Duplicate comments:
In `@package.json`:
- Around line 61-101: The dependency ranges using open-ended selectors like
">=0.30.3" (e.g., "axios", "lodash", "webpack", "yaml" and others in this block)
can allow upgrades into new major versions; change these to bounded ranges that
prevent unintended major bumps (for example ">=X.Y.Z <(X+1).0.0") or use caret
pins compatible with your stability policy so lockfile refreshes cannot jump
majors; update each affected entry (e.g., "@babel/helpers", "axios", "lodash",
"webpack", "yaml", etc.) to the appropriate ">=current <nextMajor" range.
- Around line 55-56: The engines.npm and engines.yarn fields currently use the
non-semver value "use-pnpm", which is invalid for engine checks; replace those
values with valid semver ranges (e.g., ">=8" or a specific allowed range) or
remove the engines.npm and engines.yarn keys entirely and rely on the
packageManager field to indicate pnpm; update the package.json engines.npm and
engines.yarn entries accordingly so they contain proper semver ranges (or delete
them) to avoid tooling confusion.
---
Nitpick comments:
In `@package.json`:
- Line 58: package.json pins "packageManager": "pnpm@10.33.0" but the CI uses
the pnpm setup action without a matching pinned version; update the CI pnpm
setup step (the pnpm/action-setup@v5 usage) to explicitly install pnpm@10.33.0
(or reference the same "pnpm@10.33.0" string) so the CI runner uses the exact
same pnpm version as package.json to avoid drift.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b1d4817c-8135-49e0-98be-85eb303a4529
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Actionable comments posted: 15
🧹 Nitpick comments (6)
docs/contracts-old/staking.md (1)
1-1: Rename doc file with numeric ordering prefix.This file still uses
staking.md; please align with the docs ordering convention (for example,NN_staking.md) to satisfy repository standards.As per coding guidelines, "
docs/**/*.md: Use numbered prefixes for ordering documentation files (e.g.,00_intro.md,01_tokens.md)."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/contracts-old/staking.md` at line 1, The docs file currently named "staking.md" should be renamed to follow the repository's numeric ordering convention (e.g., "NN_staking.md"); update the filename to include a two-digit numeric prefix consistent with other docs (for example "01_staking.md" or the appropriate sequence number) and ensure any internal links or references to "staking.md" are updated to the new "NN_staking.md" name (search for references to staking.md in documentation and adjust accordingly).docs/contracts/02_docs/src/policies/LoanConsolidator.sol/contract.LoanConsolidator.md (1)
361-362: Use proper bullet items for the additional revert conditions.At Line 361 and Line 375,
If ...is indented as continuation text instead of a bullet, which makes the revert-condition list ambiguous in Markdown rendering. Make these explicit list items.Proposed doc fix
- If the contract is already active, it will do nothing. +- If the contract is already active, it will do nothing. ... - If the contract is already deactivated, it will do nothing. +- If the contract is already deactivated, it will do nothing.Also applies to: 375-376
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/contracts/02_docs/src/policies/LoanConsolidator.sol/contract.LoanConsolidator.md` around lines 361 - 362, The Markdown revert-condition list in the LoanConsolidator contract docs has two sentences ("If the contract is already active..." at the location corresponding to the revert-condition list) rendered as continuation text rather than explicit list items; update the document in the LoanConsolidator section to convert those lines into proper bullet list items (e.g., prefix with a dash or asterisk) so the additional revert conditions are each distinct list entries, and ensure consistency with the other revert-condition bullets in that same list.docs/contracts/02_docs/src/bases/BasePeriodicTaskManager.sol/abstract.BasePeriodicTaskManager.md (1)
67-68: Consider simplifying "all of the" to "all the" for conciseness.Line 68 contains "all of the periodic tasks will revert" which could be more concise as "all the periodic tasks will revert."
✍️ Proposed wording simplification
- If the selector does not exist, all of the periodic tasks will revert. + If the selector does not exist, all the periodic tasks will revert.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/contracts/02_docs/src/bases/BasePeriodicTaskManager.sol/abstract.BasePeriodicTaskManager.md` around lines 67 - 68, Update the documentation text that reads "If the selector does not exist, all of the periodic tasks will revert" to use the more concise phrasing "all the periodic tasks will revert"; make this change in the comment block that references the custom selector and {task_} (the sentence describing selector existence and revert behavior).docs/contracts/02_docs/src/interfaces/IBondAuctioneer.sol/interface.IBondAuctioneer.md (2)
292-292: Optional: Simplify "take into account" → "consider".The phrase "take into account" appears twice and could be shortened to "consider" for conciseness.
✍️ Suggested simplification
-| `referrer_` | `address` | Address of referrer, used to get fees to calculate accurate payout amount. Inputting the zero address will take into account just the protocol fee. | +| `referrer_` | `address` | Address of referrer, used to get fees to calculate accurate payout amount. Inputting the zero address will consider just the protocol fee. |Apply the same change at line 313.
Also applies to: 313-313
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/contracts/02_docs/src/interfaces/IBondAuctioneer.sol/interface.IBondAuctioneer.md` at line 292, Update the parameter description for `referrer_` in the IBondAuctioneer interface docs to use "consider" instead of "take into account"; locate the two occurrences of the phrase in the description lines referencing `referrer_` (the address of referrer used to get fees to calculate accurate payout amount) and replace "take into account" with "consider" in both places (also apply the same change at the second occurrence mentioned around line 313).
144-144: Optional: Consider rewording for variety.The numbered list description contains three successive items beginning with "Minimum". While this is acceptable in a technical list context, you could improve readability by varying the phrasing (e.g., "5. Market duration floor" instead of "5. Minimum market duration").
✍️ Suggested rewording
-| `defaults_` | `uint32[6]` | Array of default values 1. Tune interval - amount of time between tuning adjustments 2. Tune adjustment delay - amount of time to apply downward tuning adjustments 3. Minimum debt decay interval - minimum amount of time to let debt decay to zero 4. Minimum deposit interval - minimum amount of time to wait between deposits 5. Minimum market duration - minimum amount of time a market can be created for 6. Minimum debt buffer - the minimum amount of debt over the initial debt to trigger a market shutdown | +| `defaults_` | `uint32[6]` | Array of default values 1. Tune interval - amount of time between tuning adjustments 2. Tune adjustment delay - amount of time to apply downward tuning adjustments 3. Minimum debt decay interval - minimum amount of time to let debt decay to zero 4. Minimum deposit interval - minimum amount of time to wait between deposits 5. Market duration floor - minimum amount of time a market can be created for 6. Debt buffer threshold - the minimum amount of debt over the initial debt to trigger a market shutdown |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/contracts/02_docs/src/interfaces/IBondAuctioneer.sol/interface.IBondAuctioneer.md` at line 144, The description for the `defaults_` (`uint32[6]`) array uses repetitive "Minimum" phrasing for items 5 and 6; update the text for clarity and variety by rewording those entries (e.g., change "5. Minimum market duration" to "5. Market duration floor" and "6. Minimum debt buffer" to "6. Debt buffer floor" or similar descriptive alternatives) while keeping the same meanings for elements referenced by `defaults_`.docs/contracts/02_docs/src/policies/deposits/LimitOrders.sol/contract.CDAuctioneerLimitOrders.md (1)
378-378: Consider simplifying "in order to" for conciseness.The phrase "in order to allow" can be shortened to "to allow" for more direct writing:
- Note that if the contract is disabled, this function will still operate in order to allow users to withdraw their deposited funds. + Note that if the contract is disabled, this function will still operate to allow users to withdraw their deposited funds.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/contracts/02_docs/src/policies/deposits/LimitOrders.sol/contract.CDAuctioneerLimitOrders.md` at line 378, Update the sentence in contract.CDAuctioneerLimitOrders documentation to be more concise by replacing "in order to allow users to withdraw their deposited funds" with "to allow users to withdraw their deposited funds"; locate the line in the CDAuctioneerLimitOrders doc where it reads "Note that if the contract is disabled, this function will still operate in order to allow users to withdraw their deposited funds." and change it to use "to allow" for brevity.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/contracts/00_overview.md`:
- Line 73: Fix the typo and pluralization in the documentation entry for `LTV
Oracle`: change "originaion" to "origination" and change "LTV's" to "LTVs" so
the line reads "`LTV Oracle` — Defines origination and liquidation LTVs." Ensure
you update the exact text string shown for the `LTV Oracle` entry.
In `@docs/contracts/01_addresses.md`:
- Around line 235-236: Remove the trailing spaces inside the inline code spans
for the contract addresses shown for "Rebalancer" and "Frax Bond": open the
markdown entries for those rows and edit the backticked address literals (the
`0x77B19aDf335143D954CD5F59A01879fA532C404e ` and
`0xc60a6656e08b62DD2644DC703d7855301363Cc38 `) to strip the final space before
the closing backtick so the code spans read
`0x77B19aDf335143D954CD5F59A01879fA532C404e` and
`0xc60a6656e08b62DD2644DC703d7855301363Cc38`.
- Around line 159-160: The table rows for Heart versions 1.1 and 1.0 are labeled
"Mainnet" but point to arbiscan.io; update those two entries (Heart 1.1 and
Heart 1.0) to have the chain/explorer column read "Arbitrum" (or "Arbitrum
Mainnet") to match the arbiscan.io links, keeping the existing
[`0x1652b5...`](https://arbiscan.io/address/0x1652b503e0f1cf38b6246ed3b91cb3786bb11656)
and
[`0xeaf46b...`](https://arbiscan.io/address/0xeaf46bd21dd9b263f28eed7260a269ffba9ace6e)
URLs; alternatively, if you prefer Ethereum mainnet, replace those arbiscan.io
URLs with the equivalent etherscan.io addresses instead.
- Around line 165-169: Remove the duplicated "Operator" rows in the Policies
(deprecated) table by deleting the second set of Operator entries (the repeated
four Mainnet Operator rows and the Goerli row) so only one canonical set
remains; locate the duplicate rows that match the Mainnet addresses
0x0AE561226896dA978EaDA0Bec4a7d3CfAE04f506,
0x0374c001204eF5e7E4F5362A5A2430CB6c219326,
0x1Ce568DbB34B2631aCDB5B453c3195EA0070EC65,
0xbb47C3FFf4eF85703907d3ffca30de278b85df3f and the Goerli address
0x61B79d10ebC48166F7495Fce5E0c352B61777460 and remove that duplicate block so
the table contains only one set of these Operator entries.
In `@docs/contracts/02_docs/src/external/cooler/Cooler.sol/contract.Cooler.md`:
- Line 268: Update the parameter description for recipient_ in the Cooler
contract docs to correct the typo: change "reciever of repayments" to "receiver
of repayments" in the table row that documents `recipient_` (the parameter name
shown as `recipient_` and type `address`).
In
`@docs/contracts/02_docs/src/external/governance/GovernorBravoDelegate.sol/contract.GovernorBravoDelegate.md`:
- Around line 532-534: Update the table description text for the quorum entry to
use the compound adjective "high-risk quorum" instead of "high risk quorum";
locate the table row showing `<none> | uint256 | The high risk quorum in number
of gOHM` in the GovernorBravoDelegate documentation and change the description
to "The high-risk quorum in number of gOHM" so the compound adjective is
hyphenated correctly.
In
`@docs/contracts/02_docs/src/interfaces/IBondAggregator.sol/interface.IBondAggregator.md`:
- Line 246: Update the param description for maxExpiry_ in the IBondAggregator
interface docs to correctly describe that maxExpiry_ is a uint256 representing
the latest acceptable vesting timestamp (e.g., "Latest acceptable vesting
timestamp for bond; set to 0 to indicate no expiry limit" or similar) and remove
the incorrect reference to a "zero address" that was copied from an address
parameter; ensure this change is made for the `maxExpiry_` entry in the
interface.IBondAggregator.md table.
In
`@docs/contracts/02_docs/src/policies/cooler/CoolerTreasuryBorrower.sol/contract.CoolerTreasuryBorrower.md`:
- Line 18: Update the phrase in the CoolerTreasuryBorrower documentation from
"non 18dp asset" to the hyphenated "non-18dp asset" for correct technical
phrasing; search for the string "non 18dp asset" in the
CoolerTreasuryBorrower.md content and replace it with "non-18dp asset" wherever
it appears (e.g., the line describing token decimals in the borrow/repay
conversion note).
In
`@docs/contracts/02_docs/src/policies/deposits/ConvertibleDepositFacility.sol/contract.ConvertibleDepositFacility.md`:
- Around line 180-182: Fix the malformed parameter names in the markdown bullets
by replacing the stray asterisks with escaped underscores so the parameters
render correctly: change "positionIds*array" to "positionIds\_array" (or better
"positionIds\_" followed by "array" as needed), "amounts* array" to "amounts\_
array" (or "amounts\_"), and "depositor\_" ensure the trailing underscore is
correctly escaped as "depositor\_" where intended; apply the same corrections
for the duplicate occurrences referenced (also at the later bullets around the
second occurrence).
- Around line 342-343: The "Notes:" line is indented and is being treated as a
nested list; unindent the "Notes:" token to the left margin so it becomes a
standalone section header/paragraph (and keep the subsequent "- If disabled,
nothing is done" line indented as the list under that Notes section); look for
the literal "Notes:" line near the "- If disabled, nothing is done" list in the
ConvertibleDepositFacility.md and remove the leading spaces before "Notes:".
In
`@docs/contracts/02_docs/src/policies/deposits/DepositManager.sol/contract.DepositManager.md`:
- Around line 247-248: Several occurrences in the DepositManager documentation
(e.g., the block starting with "This function reverts if:" near the
DepositManager contract docs) are indented by two spaces causing them to render
as nested continuation text; remove the leading two-space indentation so "This
function reverts if:" begins at the same indentation level as the preceding
text. Update the instances mentioned (around the blocks at the noted positions)
so the header and its following bullet list are flush with the main list
indentation to fix rendering.
- Around line 444-445: Replace the malformed comparison bullet "minimumDeposit*>
depositCap*" with a clear, correctly escaped inline code comparison between the
two symbols—e.g., change it to "`minimumDeposit > depositCap`" (or update the
operator to the actual relation used by the contract if different) so the note
clearly documents the intended condition involving minimumDeposit and
depositCap.
In
`@docs/contracts/02_docs/src/policies/LoanConsolidator.sol/contract.LoanConsolidator.md`:
- Around line 591-594: The `reserveTo` parameter description is awkward; update
the docs entry for `reserveTo` (field name `reserveTo`) to a clearer, consistent
phrase such as "Token in which the approval is denominated (address of the
token)" or "Token in which the approval is denominated" so it matches the style
of neighboring entries and clearly indicates it is the token address for the
approval.
In `@docs/contracts/02_docs/src/policies/Operator.sol/contract.Operator.md`:
- Line 127: The equality expression "_sReserveDecimals ==_reserveDecimals" has
missing spacing after the '==' operator; update the text so the expression reads
"_sReserveDecimals == _reserveDecimals" (i.e., add a space after '==') wherever
it appears in the Operator.sol documentation to improve readability and
consistency.
In `@README.md`:
- Line 16: Replace the phrase "CMS based editing" in the sentence that currently
reads "CMS based editing is possible via Netlify CMS, though there are some
functionality gaps / tradeoffs. See `Partial Editing with Netlify CMS` below."
with the hyphenated form "CMS-based editing" so the sentence reads "CMS-based
editing is possible via Netlify CMS..." to correct the compound-modifier
grammar.
---
Nitpick comments:
In `@docs/contracts-old/staking.md`:
- Line 1: The docs file currently named "staking.md" should be renamed to follow
the repository's numeric ordering convention (e.g., "NN_staking.md"); update the
filename to include a two-digit numeric prefix consistent with other docs (for
example "01_staking.md" or the appropriate sequence number) and ensure any
internal links or references to "staking.md" are updated to the new
"NN_staking.md" name (search for references to staking.md in documentation and
adjust accordingly).
In
`@docs/contracts/02_docs/src/bases/BasePeriodicTaskManager.sol/abstract.BasePeriodicTaskManager.md`:
- Around line 67-68: Update the documentation text that reads "If the selector
does not exist, all of the periodic tasks will revert" to use the more concise
phrasing "all the periodic tasks will revert"; make this change in the comment
block that references the custom selector and {task_} (the sentence describing
selector existence and revert behavior).
In
`@docs/contracts/02_docs/src/interfaces/IBondAuctioneer.sol/interface.IBondAuctioneer.md`:
- Line 292: Update the parameter description for `referrer_` in the
IBondAuctioneer interface docs to use "consider" instead of "take into account";
locate the two occurrences of the phrase in the description lines referencing
`referrer_` (the address of referrer used to get fees to calculate accurate
payout amount) and replace "take into account" with "consider" in both places
(also apply the same change at the second occurrence mentioned around line 313).
- Line 144: The description for the `defaults_` (`uint32[6]`) array uses
repetitive "Minimum" phrasing for items 5 and 6; update the text for clarity and
variety by rewording those entries (e.g., change "5. Minimum market duration" to
"5. Market duration floor" and "6. Minimum debt buffer" to "6. Debt buffer
floor" or similar descriptive alternatives) while keeping the same meanings for
elements referenced by `defaults_`.
In
`@docs/contracts/02_docs/src/policies/deposits/LimitOrders.sol/contract.CDAuctioneerLimitOrders.md`:
- Line 378: Update the sentence in contract.CDAuctioneerLimitOrders
documentation to be more concise by replacing "in order to allow users to
withdraw their deposited funds" with "to allow users to withdraw their deposited
funds"; locate the line in the CDAuctioneerLimitOrders doc where it reads "Note
that if the contract is disabled, this function will still operate in order to
allow users to withdraw their deposited funds." and change it to use "to allow"
for brevity.
In
`@docs/contracts/02_docs/src/policies/LoanConsolidator.sol/contract.LoanConsolidator.md`:
- Around line 361-362: The Markdown revert-condition list in the
LoanConsolidator contract docs has two sentences ("If the contract is already
active..." at the location corresponding to the revert-condition list) rendered
as continuation text rather than explicit list items; update the document in the
LoanConsolidator section to convert those lines into proper bullet list items
(e.g., prefix with a dash or asterisk) so the additional revert conditions are
each distinct list entries, and ensure consistency with the other
revert-condition bullets in that same list.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fb813cab-2cb7-4897-856a-eff8df754d93
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (265)
.claude/settings.local.json.github/workflows/build.yml.github/workflows/ci.yml.markdownlint-contracts.jsonREADME.mdbabel.config.jsdocs/contracts-old/bonds.mddocs/contracts-old/dao.mddocs/contracts-old/equations.mddocs/contracts-old/glossary.mddocs/contracts-old/interactions.mddocs/contracts-old/policy.mddocs/contracts-old/range-bound-stability.mddocs/contracts-old/staking.mddocs/contracts-old/tokens.mddocs/contracts-old/treasury.mddocs/contracts/00_overview.mddocs/contracts/01_addresses.mddocs/contracts/02_docs/_category_.jsondocs/contracts/02_docs/src/Kernel.sol/abstract.Module.mddocs/contracts/02_docs/src/Kernel.sol/abstract.Policy.mddocs/contracts/02_docs/src/Kernel.sol/contract.Kernel.mddocs/contracts/02_docs/src/bases/BaseAssetManager.sol/abstract.BaseAssetManager.mddocs/contracts/02_docs/src/bases/BasePeriodicTaskManager.sol/abstract.BasePeriodicTaskManager.mddocs/contracts/02_docs/src/bases/index.mddocs/contracts/02_docs/src/bases/interfaces/IAssetManager.sol/interface.IAssetManager.mddocs/contracts/02_docs/src/bases/interfaces/IPeriodicTaskManager.sol/interface.IPeriodicTaskManager.mddocs/contracts/02_docs/src/bases/interfaces/index.mddocs/contracts/02_docs/src/external/ClaimTransfer.sol/contract.ClaimTransfer.mddocs/contracts/02_docs/src/external/OlympusERC20.sol/abstract.EIP712.mddocs/contracts/02_docs/src/external/OlympusERC20.sol/abstract.ERC20.mddocs/contracts/02_docs/src/external/OlympusERC20.sol/abstract.ERC20Permit.mddocs/contracts/02_docs/src/external/OlympusERC20.sol/contract.OlympusERC20Token.mddocs/contracts/02_docs/src/external/OlympusERC20.sol/interface.IERC20Permit.mddocs/contracts/02_docs/src/external/OlympusERC20.sol/library.ECDSA.mddocs/contracts/02_docs/src/external/bridge/index.mddocs/contracts/02_docs/src/external/clones/CloneERC20.sol/abstract.CloneERC20.mddocs/contracts/02_docs/src/external/clones/index.mddocs/contracts/02_docs/src/external/cooler/Cooler.sol/contract.Cooler.mddocs/contracts/02_docs/src/external/cooler/CoolerCallback.sol/abstract.CoolerCallback.mddocs/contracts/02_docs/src/external/cooler/CoolerFactory.sol/contract.CoolerFactory.mddocs/contracts/02_docs/src/external/cooler/index.mddocs/contracts/02_docs/src/external/cooler/interfaces/ICooler.sol/interface.ICooler.mddocs/contracts/02_docs/src/external/cooler/interfaces/ICoolerFactory.sol/interface.ICoolerFactory.mddocs/contracts/02_docs/src/external/cooler/interfaces/index.mddocs/contracts/02_docs/src/external/governance/GovernorBravoDelegate.sol/contract.GovernorBravoDelegate.mddocs/contracts/02_docs/src/external/governance/GovernorBravoDelegator.sol/contract.GovernorBravoDelegator.mddocs/contracts/02_docs/src/external/governance/abstracts/index.mddocs/contracts/02_docs/src/external/governance/index.mddocs/contracts/02_docs/src/external/governance/interfaces/IGovernorBravoEvents.sol/interface.IGovernorBravoEventsAndErrors.mddocs/contracts/02_docs/src/external/governance/interfaces/index.mddocs/contracts/02_docs/src/external/governance/lib/ContractUtils.sol/library.ContractUtils.mddocs/contracts/02_docs/src/external/governance/lib/index.mddocs/contracts/02_docs/src/external/index.mddocs/contracts/02_docs/src/index.mddocs/contracts/02_docs/src/interfaces/IBondAggregator.sol/interface.IBondAggregator.mddocs/contracts/02_docs/src/interfaces/IBondAuctioneer.sol/interface.IBondAuctioneer.mddocs/contracts/02_docs/src/interfaces/IBondCallback.sol/interface.IBondCallback.mddocs/contracts/02_docs/src/interfaces/IBondFixedExpiryTeller.sol/interface.IBondFixedExpiryTeller.mddocs/contracts/02_docs/src/interfaces/IBondSDA.sol/interface.IBondSDA.mddocs/contracts/02_docs/src/interfaces/IBondTeller.sol/interface.IBondTeller.mddocs/contracts/02_docs/src/interfaces/IERC20BurnableMintable.sol/interface.IERC20BurnableMintable.mddocs/contracts/02_docs/src/interfaces/IERC4626.sol/interface.IERC4626.mddocs/contracts/02_docs/src/interfaces/IERC6909Wrappable.sol/interface.IERC6909Wrappable.mddocs/contracts/02_docs/src/interfaces/IEasyAuction.sol/interface.IEasyAuction.mddocs/contracts/02_docs/src/interfaces/IVersioned.sol/interface.IVersioned.mddocs/contracts/02_docs/src/interfaces/IgOHM.sol/interface.IgOHM.mddocs/contracts/02_docs/src/interfaces/Uniswap/index.mddocs/contracts/02_docs/src/interfaces/index.mddocs/contracts/02_docs/src/interfaces/maker-dao/IERC3156FlashBorrower.sol/interface.IERC3156FlashBorrower.mddocs/contracts/02_docs/src/interfaces/maker-dao/IERC3156FlashLender.sol/interface.IERC3156FlashLender.mddocs/contracts/02_docs/src/interfaces/maker-dao/index.mddocs/contracts/02_docs/src/libraries/CloneableReceiptToken.sol/contract.CloneableReceiptToken.mddocs/contracts/02_docs/src/libraries/CompoundedInterest.sol/library.CompoundedInterest.mddocs/contracts/02_docs/src/libraries/DecimalString.sol/library.DecimalString.mddocs/contracts/02_docs/src/libraries/ERC6909Wrappable.sol/abstract.ERC6909Wrappable.mddocs/contracts/02_docs/src/libraries/FullMath.sol/library.FullMath.mddocs/contracts/02_docs/src/libraries/String.sol/library.String.mddocs/contracts/02_docs/src/libraries/Timestamp.sol/library.Timestamp.mddocs/contracts/02_docs/src/libraries/TimestampLinkedList.sol/library.TimestampLinkedList.mddocs/contracts/02_docs/src/libraries/index.mddocs/contracts/02_docs/src/modules/BLREG/BLREG.v1.sol/abstract.BLREGv1.mddocs/contracts/02_docs/src/modules/BLREG/OlympusBoostedLiquidityRegistry.sol/contract.OlympusBoostedLiquidityRegistry.mddocs/contracts/02_docs/src/modules/BLREG/index.mddocs/contracts/02_docs/src/modules/CHREG/CHREG.v1.sol/abstract.CHREGv1.mddocs/contracts/02_docs/src/modules/CHREG/OlympusClearinghouseRegistry.sol/contract.OlympusClearinghouseRegistry.mddocs/contracts/02_docs/src/modules/CHREG/index.mddocs/contracts/02_docs/src/modules/DEPOS/DEPOS.v1.sol/abstract.DEPOSv1.mddocs/contracts/02_docs/src/modules/DEPOS/IDepositPositionManager.sol/interface.IDepositPositionManager.mddocs/contracts/02_docs/src/modules/DEPOS/IPositionTokenRenderer.sol/interface.IPositionTokenRenderer.mddocs/contracts/02_docs/src/modules/DEPOS/OlympusDepositPositionManager.sol/contract.OlympusDepositPositionManager.mddocs/contracts/02_docs/src/modules/DEPOS/PositionTokenRenderer.sol/contract.PositionTokenRenderer.mddocs/contracts/02_docs/src/modules/DEPOS/index.mddocs/contracts/02_docs/src/modules/DLGTE/DLGTE.v1.sol/abstract.DLGTEv1.mddocs/contracts/02_docs/src/modules/DLGTE/IDLGTE.v1.sol/interface.IDLGTEv1.mddocs/contracts/02_docs/src/modules/DLGTE/OlympusGovDelegation.sol/contract.OlympusGovDelegation.mddocs/contracts/02_docs/src/modules/DLGTE/index.mddocs/contracts/02_docs/src/modules/INSTR/OlympusInstructions.sol/contract.OlympusInstructions.mddocs/contracts/02_docs/src/modules/INSTR/index.mddocs/contracts/02_docs/src/modules/MINTR/OlympusMinter.sol/contract.OlympusMinter.mddocs/contracts/02_docs/src/modules/MINTR/index.mddocs/contracts/02_docs/src/modules/PRICE/OlympusPrice.sol/contract.OlympusPrice.mddocs/contracts/02_docs/src/modules/PRICE/PRICE.v1.sol/abstract.PRICEv1.mddocs/contracts/02_docs/src/modules/PRICE/index.mddocs/contracts/02_docs/src/modules/RANGE/OlympusRange.sol/contract.OlympusRange.mddocs/contracts/02_docs/src/modules/RANGE/RANGE.v1.sol/abstract.RANGEv1.mddocs/contracts/02_docs/src/modules/RANGE/RANGE.v2.sol/abstract.RANGEv2.mddocs/contracts/02_docs/src/modules/RANGE/index.mddocs/contracts/02_docs/src/modules/RGSTY/OlympusContractRegistry.sol/contract.OlympusContractRegistry.mddocs/contracts/02_docs/src/modules/RGSTY/RGSTY.v1.sol/abstract.RGSTYv1.mddocs/contracts/02_docs/src/modules/RGSTY/index.mddocs/contracts/02_docs/src/modules/ROLES/OlympusRoles.sol/contract.OlympusRoles.mddocs/contracts/02_docs/src/modules/ROLES/index.mddocs/contracts/02_docs/src/modules/TRSRY/OlympusTreasury.sol/contract.OlympusTreasury.mddocs/contracts/02_docs/src/modules/TRSRY/index.mddocs/contracts/02_docs/src/modules/VOTES/OlympusVotes.sol/contract.OlympusVotes.mddocs/contracts/02_docs/src/modules/VOTES/index.mddocs/contracts/02_docs/src/modules/index.mddocs/contracts/02_docs/src/periphery/CoolerComposites.sol/contract.CoolerComposites.mddocs/contracts/02_docs/src/periphery/CoolerV2Migrator.sol/contract.CoolerV2Migrator.mddocs/contracts/02_docs/src/periphery/PeripheryEnabler.sol/abstract.PeripheryEnabler.mddocs/contracts/02_docs/src/periphery/bridge/CCIPCrossChainBridge.sol/contract.CCIPCrossChainBridge.mddocs/contracts/02_docs/src/periphery/bridge/index.mddocs/contracts/02_docs/src/periphery/index.mddocs/contracts/02_docs/src/periphery/interfaces/ICCIPCrossChainBridge.sol/interface.ICCIPCrossChainBridge.mddocs/contracts/02_docs/src/periphery/interfaces/ICoolerComposites.sol/interface.ICoolerComposites.mddocs/contracts/02_docs/src/periphery/interfaces/ICoolerV2Migrator.sol/interface.ICoolerV2Migrator.mddocs/contracts/02_docs/src/periphery/interfaces/IEnabler.sol/interface.IEnabler.mddocs/contracts/02_docs/src/periphery/interfaces/index.mddocs/contracts/02_docs/src/policies/BondCallback.sol/contract.BondCallback.mddocs/contracts/02_docs/src/policies/BondManager.sol/contract.BondManager.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultLido.sol/contract.BLVaultLido.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultLusd.sol/contract.BLVaultLusd.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultManagerLido.sol/contract.BLVaultManagerLido.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultManagerLusd.sol/contract.BLVaultManagerLusd.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/index.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVault.sol/interface.IBLVault.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVaultLido.sol/interface.IBLVaultLido.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVaultManager.sol/interface.IBLVaultManager.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVaultManagerLido.sol/interface.IBLVaultManagerLido.mddocs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/index.mddocs/contracts/02_docs/src/policies/Burner.sol/contract.Burner.mddocs/contracts/02_docs/src/policies/Clearinghouse.sol/contract.Clearinghouse.mddocs/contracts/02_docs/src/policies/ContractRegistryAdmin.sol/contract.ContractRegistryAdmin.mddocs/contracts/02_docs/src/policies/CrossChainBridge.sol/contract.CrossChainBridge.mddocs/contracts/02_docs/src/policies/Distributor/Distributor.sol/contract.Distributor.mddocs/contracts/02_docs/src/policies/Distributor/index.mddocs/contracts/02_docs/src/policies/Emergency.sol/contract.Emergency.mddocs/contracts/02_docs/src/policies/EmissionManager.sol/contract.EmissionManager.mddocs/contracts/02_docs/src/policies/Heart.sol/contract.OlympusHeart.mddocs/contracts/02_docs/src/policies/LegacyBurner.sol/contract.LegacyBurner.mddocs/contracts/02_docs/src/policies/LoanConsolidator.sol/contract.LoanConsolidator.mddocs/contracts/02_docs/src/policies/Minter.sol/contract.Minter.mddocs/contracts/02_docs/src/policies/Operator.sol/contract.Operator.mddocs/contracts/02_docs/src/policies/Parthenon.sol/contract.Parthenon.mddocs/contracts/02_docs/src/policies/PriceConfig.sol/contract.OlympusPriceConfig.mddocs/contracts/02_docs/src/policies/ReserveMigrator.sol/contract.ReserveMigrator.mddocs/contracts/02_docs/src/policies/ReserveWrapper.sol/contract.ReserveWrapper.mddocs/contracts/02_docs/src/policies/TreasuryCustodian.sol/contract.TreasuryCustodian.mddocs/contracts/02_docs/src/policies/V1Migrator.sol/contract.V1Migrator.mddocs/contracts/02_docs/src/policies/VohmVault.sol/contract.VohmVault.mddocs/contracts/02_docs/src/policies/YieldRepurchaseFacility.sol/contract.YieldRepurchaseFacility.mddocs/contracts/02_docs/src/policies/bridge/BurnMintTokenPoolBase.sol/abstract.BurnMintTokenPoolBase.mddocs/contracts/02_docs/src/policies/bridge/CCIPBurnMintTokenPool.sol/contract.CCIPBurnMintTokenPool.mddocs/contracts/02_docs/src/policies/bridge/index.mddocs/contracts/02_docs/src/policies/cooler/CoolerLtvOracle.sol/contract.CoolerLtvOracle.mddocs/contracts/02_docs/src/policies/cooler/CoolerTreasuryBorrower.sol/contract.CoolerTreasuryBorrower.mddocs/contracts/02_docs/src/policies/cooler/MonoCooler.sol/contract.MonoCooler.mddocs/contracts/02_docs/src/policies/cooler/index.mddocs/contracts/02_docs/src/policies/deposits/BaseDepositFacility.sol/abstract.BaseDepositFacility.mddocs/contracts/02_docs/src/policies/deposits/ConvertibleDepositAuctioneer.sol/contract.ConvertibleDepositAuctioneer.mddocs/contracts/02_docs/src/policies/deposits/ConvertibleDepositFacility.sol/contract.ConvertibleDepositFacility.mddocs/contracts/02_docs/src/policies/deposits/DepositManager.sol/contract.DepositManager.mddocs/contracts/02_docs/src/policies/deposits/DepositRedemptionVault.sol/contract.DepositRedemptionVault.mddocs/contracts/02_docs/src/policies/deposits/LimitOrders.sol/contract.CDAuctioneerLimitOrders.mddocs/contracts/02_docs/src/policies/deposits/ReceiptTokenManager.sol/contract.ReceiptTokenManager.mddocs/contracts/02_docs/src/policies/deposits/index.mddocs/contracts/02_docs/src/policies/index.mddocs/contracts/02_docs/src/policies/interfaces/IDistributor.sol/interface.IDistributor.mddocs/contracts/02_docs/src/policies/interfaces/IEmissionManager.sol/interface.IEmissionManager.mddocs/contracts/02_docs/src/policies/interfaces/IGenericClearinghouse.sol/interface.IGenericClearinghouse.mddocs/contracts/02_docs/src/policies/interfaces/IHeart.sol/interface.IHeart.mddocs/contracts/02_docs/src/policies/interfaces/IHeart_v1_6.sol/interface.IHeart.mddocs/contracts/02_docs/src/policies/interfaces/IOperator.sol/interface.IOperator.mddocs/contracts/02_docs/src/policies/interfaces/IPOLY.sol/interface.IPOLY.mddocs/contracts/02_docs/src/policies/interfaces/IV1Migrator.sol/interface.IV1Migrator.mddocs/contracts/02_docs/src/policies/interfaces/cooler/ICoolerTreasuryBorrower.sol/interface.ICoolerTreasuryBorrower.mddocs/contracts/02_docs/src/policies/interfaces/cooler/IMonoCooler.sol/interface.IMonoCooler.mddocs/contracts/02_docs/src/policies/interfaces/cooler/index.mddocs/contracts/02_docs/src/policies/interfaces/deposits/IConvertibleDepositAuctioneer.sol/interface.IConvertibleDepositAuctioneer.mddocs/contracts/02_docs/src/policies/interfaces/deposits/IConvertibleDepositFacility.sol/interface.IConvertibleDepositFacility.mddocs/contracts/02_docs/src/policies/interfaces/deposits/IDepositFacility.sol/interface.IDepositFacility.mddocs/contracts/02_docs/src/policies/interfaces/deposits/IDepositManager.sol/interface.IDepositManager.mddocs/contracts/02_docs/src/policies/interfaces/deposits/IDepositRedemptionVault.sol/interface.IDepositRedemptionVault.mddocs/contracts/02_docs/src/policies/interfaces/deposits/ILimitOrders.sol/interface.ILimitOrders.mddocs/contracts/02_docs/src/policies/interfaces/deposits/IReceiptTokenManager.sol/interface.IReceiptTokenManager.mddocs/contracts/02_docs/src/policies/interfaces/deposits/index.mddocs/contracts/02_docs/src/policies/interfaces/index.mddocs/contracts/02_docs/src/policies/interfaces/utils/index.mddocs/contracts/02_docs/src/policies/pOLY.sol/contract.pOLY.mddocs/contracts/02_docs/src/policies/utils/PolicyAdmin.sol/abstract.PolicyAdmin.mddocs/contracts/02_docs/src/policies/utils/PolicyEnabler.sol/abstract.PolicyEnabler.mddocs/contracts/02_docs/src/policies/utils/index.mddocs/contracts/02_docs/src/proposals/CCIPBridgeSolana.sol/contract.SolanaCCIPBridgeProposal.mddocs/contracts/02_docs/src/proposals/ContractRegistryProposal.sol/contract.ContractRegistryProposal.mddocs/contracts/02_docs/src/proposals/ConvertibleDepositActivator.sol/contract.ConvertibleDepositActivator.mddocs/contracts/02_docs/src/proposals/ConvertibleDepositProposal.sol/contract.ConvertibleDepositProposal.mddocs/contracts/02_docs/src/proposals/CoolerV2DelegatesForHohmProposal.sol/contract.CoolerV2DelegatesForHohmProposal.mddocs/contracts/02_docs/src/proposals/CoolerV2Proposal.sol/contract.CoolerV2Proposal.mddocs/contracts/02_docs/src/proposals/EmissionManagerProposal.sol/contract.EmissionManagerProposal.mddocs/contracts/02_docs/src/proposals/LoanConsolidatorProposal.sol/contract.LoanConsolidatorProposal.mddocs/contracts/02_docs/src/proposals/MigrationProposal.sol/contract.MigrationProposal.mddocs/contracts/02_docs/src/proposals/MigrationProposalHelper.sol/contract.MigrationProposalHelper.mddocs/contracts/02_docs/src/proposals/OIP_166.sol/contract.OIP_166.mddocs/contracts/02_docs/src/proposals/OIP_168.sol/contract.OIP_168.mddocs/contracts/02_docs/src/proposals/OIP_170.sol/contract.OIP_170.mddocs/contracts/02_docs/src/proposals/OIP_XXX.sol/contract.OIP_XXX.mddocs/contracts/02_docs/src/proposals/index.mddocs/governance/00_governance.mddocs/governance/01_proposal_lifecycle.mddocs/governance/02_proposal_submission.mddocs/legacy/02_bonding.mddocs/legacy/04_boosted-liq-vaults.mddocs/legacy/05_policy.mddocs/legacy/06_dao-processes/_category_.jsondocs/legacy/07_coolers.mddocs/legacy/08_migration.mddocs/literature-content/media.mdxdocs/mechanics/governance/index.mddocs/mechanics/stability/range-bound.mddocs/overview/00_intro.mddocs/overview/01_tokens.mddocs/overview/02_treasury.mddocs/overview/03_pol.mddocs/overview/04_cooler-loans.mddocs/overview/05_emissions-manager.mddocs/overview/06_yield-repurchase-facility.mddocs/overview/08_range-bound.mddocs/overview/09_convertible-deposits.mddocs/partnership/frax-partnership.mddocs/partnership/rari-partnership/README.mddocs/partnership/rari-partnership/fuse.mddocs/protocol-internals/initial-network-state.mddocs/protocol-internals/market-dynamics.mddocs/protocol-internals/policy.mddocs/publications/00_papers.mddocs/publications/01_ohm-bond-paper.mddocs/publications/_category_.jsondocs/resources/00_assets.mddocs/security/01_roles.mddocs/security/02_audits.mddocs/security/03_bugbounty.mddocs/user-guides/00_using-website/_category_.jsondocs/user-guides/00_using-website/staking.mdxdocs/user-guides/01_using-etherscan/_category_.jsondocs/user-guides/01_using-etherscan/staking.mddocs/user-guides/01_using-etherscan/unstaking.mddocusaurus.config.jspackage.jsonsrc/components/HomepageFeatures/index.tsxsrc/css/custom.csssrc/pages/index.module.csssrc/pages/index.tsxstatic/admin/config.ymlstatic/admin/index.html
💤 Files with no reviewable changes (39)
- docs/contracts/02_docs/src/modules/ROLES/index.md
- docs/contracts/02_docs/src/modules/MINTR/index.md
- docs/contracts/02_docs/src/interfaces/maker-dao/index.md
- docs/contracts/02_docs/src/modules/RANGE/index.md
- docs/contracts/02_docs/src/modules/index.md
- docs/contracts/02_docs/src/modules/CHREG/index.md
- docs/contracts/02_docs/src/modules/RGSTY/index.md
- docs/contracts/02_docs/src/external/index.md
- docs/contracts/02_docs/src/external/governance/abstracts/index.md
- docs/contracts/02_docs/src/policies/deposits/index.md
- docs/contracts/02_docs/src/policies/Distributor/index.md
- docs/contracts/02_docs/src/external/governance/interfaces/index.md
- docs/contracts/02_docs/src/interfaces/index.md
- docs/contracts/02_docs/src/interfaces/Uniswap/index.md
- docs/contracts/02_docs/src/external/clones/index.md
- docs/contracts/02_docs/src/modules/INSTR/index.md
- docs/contracts/02_docs/src/modules/DEPOS/index.md
- docs/contracts/02_docs/src/modules/BLREG/index.md
- docs/contracts/02_docs/src/external/governance/index.md
- docs/contracts/02_docs/src/index.md
- docs/contracts/02_docs/src/modules/PRICE/index.md
- docs/contracts/02_docs/src/periphery/interfaces/index.md
- docs/contracts/02_docs/src/libraries/index.md
- docs/contracts/02_docs/src/modules/VOTES/index.md
- docs/contracts/02_docs/src/modules/TRSRY/index.md
- docs/contracts/02_docs/src/bases/interfaces/index.md
- docs/contracts/02_docs/src/periphery/index.md
- docs/contracts/02_docs/src/external/bridge/index.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/index.md
- docs/contracts/02_docs/src/external/cooler/index.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/index.md
- docs/contracts/02_docs/src/external/cooler/interfaces/index.md
- docs/contracts/02_docs/src/external/governance/lib/index.md
- docs/contracts/02_docs/src/bases/index.md
- docs/contracts/02_docs/src/policies/bridge/index.md
- docs/contracts/02_docs/src/policies/cooler/index.md
- docs/contracts/02_docs/src/policies/index.md
- docs/contracts/02_docs/src/modules/DLGTE/index.md
- docs/contracts/02_docs/src/periphery/bridge/index.md
✅ Files skipped from review due to trivial changes (125)
- .claude/settings.local.json
- docs/contracts-old/interactions.md
- .github/workflows/ci.yml
- docs/contracts-old/policy.md
- docs/contracts-old/dao.md
- docs/contracts/02_docs/src/interfaces/IERC20BurnableMintable.sol/interface.IERC20BurnableMintable.md
- docs/contracts/02_docs/src/modules/BLREG/OlympusBoostedLiquidityRegistry.sol/contract.OlympusBoostedLiquidityRegistry.md
- docs/contracts-old/range-bound-stability.md
- babel.config.js
- docs/contracts/02_docs/src/interfaces/IEasyAuction.sol/interface.IEasyAuction.md
- .markdownlint-contracts.json
- docs/contracts-old/equations.md
- docs/contracts-old/treasury.md
- docs/contracts/02_docs/src/interfaces/IVersioned.sol/interface.IVersioned.md
- docs/contracts/02_docs/src/policies/interfaces/IHeart.sol/interface.IHeart.md
- docs/contracts/02_docs/src/external/governance/lib/ContractUtils.sol/library.ContractUtils.md
- docs/contracts/02_docs/src/libraries/CompoundedInterest.sol/library.CompoundedInterest.md
- docs/contracts/02_docs/src/policies/VohmVault.sol/contract.VohmVault.md
- docs/contracts/02_docs/src/modules/DEPOS/DEPOS.v1.sol/abstract.DEPOSv1.md
- docs/contracts/02_docs/src/external/OlympusERC20.sol/abstract.ERC20.md
- docs/contracts/02_docs/src/modules/DLGTE/IDLGTE.v1.sol/interface.IDLGTEv1.md
- docs/contracts/02_docs/src/external/OlympusERC20.sol/abstract.ERC20Permit.md
- docs/contracts/02_docs/src/Kernel.sol/abstract.Policy.md
- docs/contracts/02_docs/src/modules/MINTR/OlympusMinter.sol/contract.OlympusMinter.md
- docs/contracts/02_docs/src/modules/INSTR/OlympusInstructions.sol/contract.OlympusInstructions.md
- docs/contracts-old/glossary.md
- docs/contracts/02_docs/src/interfaces/maker-dao/IERC3156FlashBorrower.sol/interface.IERC3156FlashBorrower.md
- docs/contracts/02_docs/src/modules/CHREG/CHREG.v1.sol/abstract.CHREGv1.md
- docs/contracts/02_docs/src/external/OlympusERC20.sol/contract.OlympusERC20Token.md
- docs/contracts/02_docs/src/policies/Emergency.sol/contract.Emergency.md
- docs/contracts/02_docs/category.json
- docs/contracts/02_docs/src/Kernel.sol/abstract.Module.md
- docs/contracts/02_docs/src/interfaces/maker-dao/IERC3156FlashLender.sol/interface.IERC3156FlashLender.md
- docs/contracts/02_docs/src/modules/DEPOS/IPositionTokenRenderer.sol/interface.IPositionTokenRenderer.md
- docs/contracts/02_docs/src/modules/TRSRY/OlympusTreasury.sol/contract.OlympusTreasury.md
- docs/contracts/02_docs/src/external/cooler/CoolerFactory.sol/contract.CoolerFactory.md
- docs/contracts/02_docs/src/policies/PriceConfig.sol/contract.OlympusPriceConfig.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVaultManager.sol/interface.IBLVaultManager.md
- docs/contracts/02_docs/src/modules/BLREG/BLREG.v1.sol/abstract.BLREGv1.md
- docs/contracts/02_docs/src/policies/Distributor/Distributor.sol/contract.Distributor.md
- docs/contracts/02_docs/src/policies/Burner.sol/contract.Burner.md
- docs/contracts/02_docs/src/modules/ROLES/OlympusRoles.sol/contract.OlympusRoles.md
- docs/contracts/02_docs/src/modules/RGSTY/RGSTY.v1.sol/abstract.RGSTYv1.md
- docs/contracts/02_docs/src/libraries/Timestamp.sol/library.Timestamp.md
- docs/contracts/02_docs/src/external/governance/interfaces/IGovernorBravoEvents.sol/interface.IGovernorBravoEventsAndErrors.md
- docs/contracts/02_docs/src/bases/interfaces/IAssetManager.sol/interface.IAssetManager.md
- docs/contracts-old/bonds.md
- docs/contracts/02_docs/src/periphery/interfaces/ICoolerV2Migrator.sol/interface.ICoolerV2Migrator.md
- docs/contracts/02_docs/src/external/clones/CloneERC20.sol/abstract.CloneERC20.md
- docs/contracts/02_docs/src/libraries/FullMath.sol/library.FullMath.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVaultLido.sol/interface.IBLVaultLido.md
- docs/contracts/02_docs/src/policies/TreasuryCustodian.sol/contract.TreasuryCustodian.md
- docs/contracts/02_docs/src/periphery/CoolerComposites.sol/contract.CoolerComposites.md
- docs/contracts/02_docs/src/interfaces/IgOHM.sol/interface.IgOHM.md
- docs/contracts/02_docs/src/policies/Clearinghouse.sol/contract.Clearinghouse.md
- docs/contracts/02_docs/src/interfaces/IERC6909Wrappable.sol/interface.IERC6909Wrappable.md
- docs/contracts/02_docs/src/interfaces/IBondCallback.sol/interface.IBondCallback.md
- docs/contracts/02_docs/src/policies/LegacyBurner.sol/contract.LegacyBurner.md
- docs/contracts/02_docs/src/interfaces/IBondTeller.sol/interface.IBondTeller.md
- docs/contracts/02_docs/src/periphery/interfaces/IEnabler.sol/interface.IEnabler.md
- docs/contracts/02_docs/src/libraries/DecimalString.sol/library.DecimalString.md
- docs/contracts/02_docs/src/policies/Parthenon.sol/contract.Parthenon.md
- docs/contracts/02_docs/src/modules/VOTES/OlympusVotes.sol/contract.OlympusVotes.md
- docs/contracts/02_docs/src/external/governance/GovernorBravoDelegator.sol/contract.GovernorBravoDelegator.md
- docs/contracts/02_docs/src/periphery/PeripheryEnabler.sol/abstract.PeripheryEnabler.md
- docs/contracts/02_docs/src/libraries/String.sol/library.String.md
- docs/contracts/02_docs/src/external/cooler/CoolerCallback.sol/abstract.CoolerCallback.md
- docs/contracts/02_docs/src/libraries/CloneableReceiptToken.sol/contract.CloneableReceiptToken.md
- docs/contracts/02_docs/src/interfaces/IERC4626.sol/interface.IERC4626.md
- docs/contracts/02_docs/src/modules/CHREG/OlympusClearinghouseRegistry.sol/contract.OlympusClearinghouseRegistry.md
- docs/contracts/02_docs/src/policies/cooler/CoolerLtvOracle.sol/contract.CoolerLtvOracle.md
- docs/contracts/02_docs/src/modules/PRICE/PRICE.v1.sol/abstract.PRICEv1.md
- docs/contracts/02_docs/src/policies/deposits/BaseDepositFacility.sol/abstract.BaseDepositFacility.md
- docs/contracts/02_docs/src/modules/DLGTE/DLGTE.v1.sol/abstract.DLGTEv1.md
- docs/contracts/02_docs/src/interfaces/IBondSDA.sol/interface.IBondSDA.md
- docs/contracts/02_docs/src/libraries/TimestampLinkedList.sol/library.TimestampLinkedList.md
- docs/contracts/02_docs/src/policies/Minter.sol/contract.Minter.md
- docs/contracts/02_docs/src/periphery/interfaces/ICoolerComposites.sol/interface.ICoolerComposites.md
- docs/contracts/02_docs/src/bases/BaseAssetManager.sol/abstract.BaseAssetManager.md
- docs/contracts/02_docs/src/policies/interfaces/IDistributor.sol/interface.IDistributor.md
- docs/contracts/02_docs/src/modules/RANGE/RANGE.v2.sol/abstract.RANGEv2.md
- docs/contracts/02_docs/src/Kernel.sol/contract.Kernel.md
- docs/contracts/02_docs/src/modules/RGSTY/OlympusContractRegistry.sol/contract.OlympusContractRegistry.md
- docs/contracts/02_docs/src/modules/RANGE/OlympusRange.sol/contract.OlympusRange.md
- docs/contracts/02_docs/src/modules/RANGE/RANGE.v1.sol/abstract.RANGEv1.md
- docs/contracts/02_docs/src/policies/BondManager.sol/contract.BondManager.md
- docs/contracts/02_docs/src/policies/ReserveMigrator.sol/contract.ReserveMigrator.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultLusd.sol/contract.BLVaultLusd.md
- docs/contracts/02_docs/src/modules/DEPOS/OlympusDepositPositionManager.sol/contract.OlympusDepositPositionManager.md
- docs/contracts/02_docs/src/policies/interfaces/IEmissionManager.sol/interface.IEmissionManager.md
- docs/contracts/02_docs/src/policies/bridge/BurnMintTokenPoolBase.sol/abstract.BurnMintTokenPoolBase.md
- docs/contracts/02_docs/src/periphery/interfaces/ICCIPCrossChainBridge.sol/interface.ICCIPCrossChainBridge.md
- docs/contracts/02_docs/src/policies/ContractRegistryAdmin.sol/contract.ContractRegistryAdmin.md
- docs/contracts/02_docs/src/modules/DEPOS/PositionTokenRenderer.sol/contract.PositionTokenRenderer.md
- docs/contracts/02_docs/src/interfaces/IBondFixedExpiryTeller.sol/interface.IBondFixedExpiryTeller.md
- docs/contracts/02_docs/src/external/ClaimTransfer.sol/contract.ClaimTransfer.md
- docs/contracts/02_docs/src/modules/PRICE/OlympusPrice.sol/contract.OlympusPrice.md
- docs/contracts/02_docs/src/policies/YieldRepurchaseFacility.sol/contract.YieldRepurchaseFacility.md
- docs/contracts/02_docs/src/modules/DLGTE/OlympusGovDelegation.sol/contract.OlympusGovDelegation.md
- docs/contracts/02_docs/src/external/cooler/interfaces/ICoolerFactory.sol/interface.ICoolerFactory.md
- docs/contracts/02_docs/src/policies/deposits/ReceiptTokenManager.sol/contract.ReceiptTokenManager.md
- docs/contracts/02_docs/src/policies/V1Migrator.sol/contract.V1Migrator.md
- docs/contracts/02_docs/src/policies/EmissionManager.sol/contract.EmissionManager.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultManagerLido.sol/contract.BLVaultManagerLido.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVault.sol/interface.IBLVault.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultLido.sol/contract.BLVaultLido.md
- docs/contracts/02_docs/src/external/OlympusERC20.sol/library.ECDSA.md
- docs/contracts/02_docs/src/external/OlympusERC20.sol/interface.IERC20Permit.md
- docs/contracts/02_docs/src/periphery/CoolerV2Migrator.sol/contract.CoolerV2Migrator.md
- docs/contracts/02_docs/src/policies/ReserveWrapper.sol/contract.ReserveWrapper.md
- docs/contracts/02_docs/src/periphery/bridge/CCIPCrossChainBridge.sol/contract.CCIPCrossChainBridge.md
- docs/contracts/02_docs/src/policies/BondCallback.sol/contract.BondCallback.md
- docs/contracts/02_docs/src/libraries/ERC6909Wrappable.sol/abstract.ERC6909Wrappable.md
- docs/contracts/02_docs/src/policies/CrossChainBridge.sol/contract.CrossChainBridge.md
- docs/contracts/02_docs/src/policies/bridge/CCIPBurnMintTokenPool.sol/contract.CCIPBurnMintTokenPool.md
- docs/contracts/02_docs/src/external/OlympusERC20.sol/abstract.EIP712.md
- docs/contracts/02_docs/src/policies/interfaces/IGenericClearinghouse.sol/interface.IGenericClearinghouse.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/BLVaultManagerLusd.sol/contract.BLVaultManagerLusd.md
- docs/contracts/02_docs/src/modules/DEPOS/IDepositPositionManager.sol/interface.IDepositPositionManager.md
- docs/contracts/02_docs/src/external/cooler/interfaces/ICooler.sol/interface.ICooler.md
- docs/contracts/02_docs/src/policies/deposits/DepositRedemptionVault.sol/contract.DepositRedemptionVault.md
- docs/contracts/02_docs/src/bases/interfaces/IPeriodicTaskManager.sol/interface.IPeriodicTaskManager.md
- docs/contracts/02_docs/src/policies/BoostedLiquidity/interfaces/IBLVaultManagerLido.sol/interface.IBLVaultManagerLido.md
- docs/contracts/02_docs/src/policies/Heart.sol/contract.OlympusHeart.md
- docs/contracts/02_docs/src/policies/cooler/MonoCooler.sol/contract.MonoCooler.md
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build.yml
|
|
||
| - `MonoCooler` — Core contract managing cooler loan states, lender-owned contract that manages loan workflows including fulfilling requests, and rebalancing funds to/from Olympus Treasury. | ||
| - `LTV Oracle` — Defines originaion and liquidation LTV's. | ||
| - `LTV Oracle` — Defines originaion and liquidation LTV's. |
There was a problem hiding this comment.
Fix typo and acronym pluralization on Line 73.
originaion should be origination, and LTV's should be LTVs.
Suggested fix
-- `LTV Oracle` — Defines originaion and liquidation LTV's.
+- `LTV Oracle` — Defines origination and liquidation LTVs.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - `LTV Oracle` — Defines originaion and liquidation LTV's. | |
| - `LTV Oracle` — Defines origination and liquidation LTVs. |
🧰 Tools
🪛 LanguageTool
[grammar] ~73-~73: Ensure spelling is correct
Context: ...mpus Treasury. - LTV Oracle — Defines originaion and liquidation LTV's. - `Treasury Borr...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/contracts/00_overview.md` at line 73, Fix the typo and pluralization in
the documentation entry for `LTV Oracle`: change "originaion" to "origination"
and change "LTV's" to "LTVs" so the line reads "`LTV Oracle` — Defines
origination and liquidation LTVs." Ensure you update the exact text string shown
for the `LTV Oracle` entry.
Comment on lines
+159
to
+160
| | Heart | 1.1 | Mainnet | [`0x1652b503e0f1cf38b6246ed3b91cb3786bb11656`](https://arbiscan.io/address/0x1652b503e0f1cf38b6246ed3b91cb3786bb11656) | | ||
| | Heart | 1.0 | Mainnet | [`0xeaf46bd21dd9b263f28eed7260a269ffba9ace6e`](https://arbiscan.io/address/0xeaf46bd21dd9b263f28eed7260a269ffba9ace6e) | |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
wc -l docs/contracts/01_addresses.mdRepository: OlympusDAO/olympus-docs
Length of output: 101
🏁 Script executed:
sed -n '150,170p' docs/contracts/01_addresses.mdRepository: OlympusDAO/olympus-docs
Length of output: 3699
🏁 Script executed:
head -30 docs/contracts/01_addresses.mdRepository: OlympusDAO/olympus-docs
Length of output: 3516
Fix chain/explorer mismatch: Lines 159-160 labeled "Mainnet" but link to Arbiscan.
Heart versions 1.1 and 1.0 are marked as Mainnet but both URLs point to arbiscan.io, which is the Arbitrum explorer. These should either be relabeled as Arbitrum or the URLs corrected to use etherscan.io to match Ethereum mainnet addresses.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/contracts/01_addresses.md` around lines 159 - 160, The table rows for
Heart versions 1.1 and 1.0 are labeled "Mainnet" but point to arbiscan.io;
update those two entries (Heart 1.1 and Heart 1.0) to have the chain/explorer
column read "Arbitrum" (or "Arbitrum Mainnet") to match the arbiscan.io links,
keeping the existing
[`0x1652b5...`](https://arbiscan.io/address/0x1652b503e0f1cf38b6246ed3b91cb3786bb11656)
and
[`0xeaf46b...`](https://arbiscan.io/address/0xeaf46bd21dd9b263f28eed7260a269ffba9ace6e)
URLs; alternatively, if you prefer Ethereum mainnet, replace those arbiscan.io
URLs with the equivalent etherscan.io addresses instead.
| | Name | Type | Description | | ||
| | ------------ | --------- | ---------------------- | | ||
| | `loanID_` | `uint256` | of lender's loan. | | ||
| | `recipient_` | `address` | reciever of repayments | |
There was a problem hiding this comment.
Fix typo in parameter description (reciever → receiver).
Line 268 has a spelling error in user-facing docs: “reciever of repayments” should be “receiver of repayments.”
Suggested fix
-| `recipient_` | `address` | reciever of repayments |
+| `recipient_` | `address` | receiver of repayments |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| | `recipient_` | `address` | reciever of repayments | | |
| | `recipient_` | `address` | receiver of repayments | |
🧰 Tools
🪛 LanguageTool
[grammar] ~268-~268: Ensure spelling is correct
Context: ...an. | | recipient_ | address | reciever of repayments | ### collateralFor Com...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/contracts/02_docs/src/external/cooler/Cooler.sol/contract.Cooler.md` at
line 268, Update the parameter description for recipient_ in the Cooler contract
docs to correct the typo: change "reciever of repayments" to "receiver of
repayments" in the table row that documents `recipient_` (the parameter name
shown as `recipient_` and type `address`).
Comment on lines
+444
to
+445
| - minimumDeposit*> depositCap* | ||
| Notes: |
There was a problem hiding this comment.
Comparison bullet is malformed (minimumDeposit*> depositCap*).
This appears to be an escaping/format artifact and no longer clearly documents the actual condition.
Suggested fix
-- minimumDeposit*> depositCap*
+- `minimumDeposit_` > `depositCap_`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - minimumDeposit*> depositCap* | |
| Notes: | |
| - `minimumDeposit_` > `depositCap_` | |
| Notes: |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@docs/contracts/02_docs/src/policies/deposits/DepositManager.sol/contract.DepositManager.md`
around lines 444 - 445, Replace the malformed comparison bullet
"minimumDeposit*> depositCap*" with a clear, correctly escaped inline code
comparison between the two symbols—e.g., change it to "`minimumDeposit >
depositCap`" (or update the operator to the actual relation used by the contract
if different) so the note clearly documents the intended condition involving
minimumDeposit and depositCap.
| * Full Editing functionality is possible by following `Installation`, `Local Development` and `Build` steps below. | ||
| * CMS based editing is possible via Netlify CMS, though there are some functionality gaps / tradeoffs. See `Partial Editing with Netlify CMS` below. | ||
| - Full Editing functionality is possible by following `Installation`, `Local Development` and `Build` steps below. | ||
| - CMS based editing is possible via Netlify CMS, though there are some functionality gaps / tradeoffs. See `Partial Editing with Netlify CMS` below. |
There was a problem hiding this comment.
Hyphenate “CMS-based” for correct grammar.
Use “CMS-based editing” instead of “CMS based editing” for standard compound-modifier usage.
🧰 Tools
🪛 LanguageTool
[grammar] ~16-~16: Use a hyphen to join words.
Context: ...elopmentandBuild` steps below. - CMS based editing is possible via Netlify CM...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 16, Replace the phrase "CMS based editing" in the sentence
that currently reads "CMS based editing is possible via Netlify CMS, though
there are some functionality gaps / tradeoffs. See `Partial Editing with Netlify
CMS` below." with the hyphenated form "CMS-based editing" so the sentence reads
"CMS-based editing is possible via Netlify CMS..." to correct the
compound-modifier grammar.
This reverts commit 146579b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by CodeRabbit