Fixes issue with suggestions element scroll position#23
Open
DallasEpperson wants to merge 1 commit intoOne-com:masterfrom
Open
Fixes issue with suggestions element scroll position#23DallasEpperson wants to merge 1 commit intoOne-com:masterfrom
DallasEpperson wants to merge 1 commit intoOne-com:masterfrom
Conversation
…as been deprecated in favor of window.pageYOffset.
Author
|
@hanstdam would you mind taking a look at this for me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue stems from using document.body.scrollTop. That function has been deprecated in modern browsers and seems to always return 0, no matter the scroll position of the viewport.
Replaced with window.pageYOffset, but gracefully falls back to older functions if needed. This fixes #22.