Fix crash when adding alias with some labels #2296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing some labels to User.addAlias, such as "AL" this could
cause a crash when starting the app the next time. This is due to
casting the wrong type as initializeFromJson's code used a contains
instead of an equals which can result in finding the wrong function.
To correct this switched this to equals("get$property", true) instead
and also added a check for it.parameterCount == 0 as we only want to
cast based on getters.
Also added tests for IdentityModel with a number of labels to ensure
this code changes covers common label values.
Lastly also removed the if (method == null) check to simplify the code,
as the when statement can handle this case.
jinliu9508
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
When passing some labels to
User.addAlias, such as "AL", would cause a crash when starting the app the next time.Details
This is due to casting the wrong type as initializeFromJson's code used a contains instead of an equals which can result in finding the wrong function.
To correct this switched this to equals("get$property", true) instead and also added a check for it.parameterCount == 0 as we only want to cast based on getters.
Lastly also removed the if (method == null) check to simplify the code, as the when statement can handle this case.
Related
This address issue #2279
Motivation
Valid input values to the SDK should not cause crashes.
Scope
Affects casting logic loading Models from storage on app startup.
Testing
Unit testing
Also added tests for IdentityModel with a number of labels to ensure this code changes covers common label values.
Manual testing
Tested on an Android 14 emulator, added an alias with the label "AL", reproduced crash, and ensured no longer crashes after the fix.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is