Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 3, 2025

Description

One Line Summary

Update release workflow for version bumps, building, creating GitHub releases, pushing to XCFramework repository, and pushing to Cocoapods.

Details - Workflow steps:

1. Create Release PR (create-release-prs.yml)

  • Automates version bumps
  • Create PR in OneSignal-iOS-SDK
  • Create PR in OneSignal-XCFramework SDK

⏸️ Action Needed: Approve and merge PRs

2. Create GitHub Release in OneSignal-iOS-SDK (create_github_release.yml)

  • Makes release on GitHub and attaches the 10 generated xcframework zip files.
  • We can test at this point before pushing to Cocoapods

⏸️ Action Needed (optional): Here is chance to test releases before pushing out to package managers

3. Release SDK (publish-release.yml)

  • Push to cocoapods with OneSignal and OneSignalXCFramework
  • Make OneSignal-XCFramework release for Swift Package Manager

Motivation

Automate release workflow

Scope

Release workflow

Testing

Manual testing

Testing through manual triggers

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

These methods are unused, leftover dead code.
@nan-li nan-li force-pushed the chore/cd_create_release_pr branch 4 times, most recently from 06f8097 to fdb343a Compare November 6, 2025 05:27
* This script will read the VERSION and update the 2 podspec files and the ONESIGNAL_VERSION's in the SDK
* Add this to the CD script as a step.
* This is similar to existing scripts `update_swift_package.sh` and `build_all_frameworks.sh`
- Also, rename cd.yml to create-release-prs.yml for clarity
Creates GH release for OneSignal-iOS-SDK.
Does not create release for OneSignal-XCFramework
@nan-li nan-li force-pushed the chore/cd_create_release_pr branch from fdb343a to e1d53ad Compare November 6, 2025 16:21
@nan-li nan-li requested a review from a team November 6, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants