When (re-)generating the CSV file use minimal quoting#9
Open
aplaice wants to merge 1 commit intoOnkelTem:masterfrom
Open
When (re-)generating the CSV file use minimal quoting#9aplaice wants to merge 1 commit intoOnkelTem:masterfrom
aplaice wants to merge 1 commit intoOnkelTem:masterfrom
Conversation
(Quote only when the field contains `,` `"` or a new line, not when it contains a space, but not the other characters.) This is a rather hack-ish solution. It's also the first PHP code that I've ever written (other than fiddling with mediawiki and wordpress templates several years ago), so it may well not be very pretty code. I haven't seen a noticeable slow-down when running `composer index` on the anki-ultimate-geography deck, though. I decided to write with fputcsv to a temporary buffer and then patch this output, to avoid writing my own CSV parser and possibly introduce my own bugs.
Author
|
(This is obviously linked to #8.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Quote only when the field contains
,"or a new line, not when it contains a space, but not the other characters.)This is a rather hack-ish solution. It's also the first PHP code that I've ever written (other than fiddling with mediawiki and wordpress templates several years ago), so it may well not be very pretty code. I haven't seen a noticeable slow-down when running
composer indexon the anki-ultimate-geography deck, though.I decided to write with fputcsv to a temporary buffer and then patch this output, to avoid writing my own CSV parser and possibly introducing my own bugs.