Skip to content

[CI] Disable C++20 module build to fix CI failures #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Luohaothu wants to merge 7 commits into from
Closed

[CI] Disable C++20 module build to fix CI failures #91

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
66008bb
[CI] Disable C++20 module build to fix CI failures
Luohaothu Feb 4, 2026
ee6749c
Fix CMake build directory configuration
Luohaothu Feb 4, 2026
716746c
[CI] Code auto formatted
Feb 4, 2026
dd846bd
Fix CMake INTERFACE target properties for non-module builds
Luohaothu Feb 4, 2026
054f602
Use proper INTERFACE/PUBLIC scope handling from fix-module
Luohaothu Feb 4, 2026
63b73ab
Fix OPFLOW_TARGET_SCOPE definition order
Luohaothu Feb 4, 2026
1ee3e68
Merge branch 'master' into ci/disable-module-build
Luohaothu Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if(OPFLOW_ENABLE_MODULE)
# ----------------------------------------------------------------------------
add_library(opflow)

target_compile_definitions(opflow PUBLIC OPFLOW_USE_MODULE)
target_compile_definitions(opflow PRIVATE OPFLOW_USE_MODULE)
set_property(TARGET opflow PROPERTY CXX_SCAN_FOR_MODULES ON)
target_sources(opflow
PUBLIC FILE_SET CXX_MODULES
Expand All @@ -42,7 +42,7 @@ if(OPFLOW_ENABLE_MODULE)
FILE_SET HEADERS DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
else()
# ----------------------------------------------------------------------------
# C++20 header only version
# C++26 header only version
# ----------------------------------------------------------------------------
add_library(opflow INTERFACE)
set_property(TARGET opflow PROPERTY CXX_SCAN_FOR_MODULES OFF)
Expand All @@ -59,6 +59,13 @@ else()
endif()
add_library(opflow::opflow ALIAS opflow)

# Set OPFLOW_TARGET_SCOPE based on module enable status
if(OPFLOW_ENABLE_MODULE)
set(OPFLOW_TARGET_SCOPE PUBLIC)
else()
set(OPFLOW_TARGET_SCOPE INTERFACE)
endif()

# Create & include the version header
configure_file(${CMAKE_CURRENT_LIST_DIR}/../cmake/Version.hpp.in ${CMAKE_BINARY_DIR}/Version.hpp @ONLY)

Expand Down Expand Up @@ -120,3 +127,25 @@ target_link_options(opflow
INTERFACE $<$<BOOL:${OPFLOW_SANITIZE_LEAK}>: -fsanitize=leak>
INTERFACE $<$<BOOL:${OPFLOW_SANITIZE_THREAD}>: -fsanitize=thread>
INTERFACE $<$<BOOL:${OPFLOW_SANITIZE_UB}>: -fsanitize=undefined>)

# ----------------------------------------------------------------------------
# Compiler warnings
# ----------------------------------------------------------------------------
# Enable strict warnings and treat warnings as errors by default

if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(opflow ${OPFLOW_TARGET_SCOPE}
-Wall
-Wextra
-Werror
# Suppress possible ABI warning from compiler upgrades
-Wno-psabi
)
endif()
# MSVC-specific warnings
if(MSVC)
target_compile_options(opflow ${OPFLOW_TARGET_SCOPE}
/W4
/WX
)
endif()
Loading