feat: migrate build and dependencies to conda-only workflow#93
feat: migrate build and dependencies to conda-only workflow#93
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Luohaothu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the OpFlow project's build and dependency management by transitioning to a conda-centric workflow. This change streamlines the build process, enhances maintainability by removing vendored external libraries, and introduces robust variant support for key components like MPI and OpenMP. The updated CMake logic now exclusively leverages Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant and positive refactoring that migrates the project's build system to a modern, conda-only workflow. By removing vendored dependencies and using find_package in CMake, the build process is greatly simplified and dependency management becomes much cleaner. The new conda recipes are well-structured. I've found a couple of minor issues in the new conda recipe files that would prevent a successful build, and I've provided suggestions to fix them. Overall, this is an excellent improvement for the project.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c54b1e22db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
💡 Codex Review Pass scalar zero to Struct RHS pinning call
In ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6be0f0de0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| package_paths.txt | ||
| ${{ steps.croot.outputs.croot }}/${{ matrix.platform }}/opflow-*.conda |
There was a problem hiding this comment.
Including package_paths.txt in the artifact path list means if-no-files-found: error will still pass even when the actual package glob matches nothing, because the text file is always present. In scenarios where the built package name/path differs (for example, different package format or output location), this job reports success while uploading no conda package, which can silently break downstream release consumption.
Useful? React with 👍 / 👎.
|
@codex review |
💡 Codex Review Pass scalar value to HYPRE_StructVectorSetValues
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Escape CMake variable interpolation in generated toolchain template. Separate debug/release configure presets so Ninja release builds use CMAKE_BUILD_TYPE=Release.
Add OPFLOW_WITH_TECIO toggle and disable TecIO in CI/conda recipe paths. Guard TecIO-specific test/code paths and allow MPI builds to skip teciompi when unavailable.
1 participant
Summary
Test Plan