-
Notifications
You must be signed in to change notification settings - Fork 8
Added badges to the README.md file #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
KeilChris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have three license badges? The Apache 2.0 and GPL v3.0 and later should suffice.
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am about to head off into the weekend. I'll mark as "request changes" as I'd like to understand why we need this huge amount of badges.
Also, I added this in the past to the workflow to remove them before packaging the VSIX file for consumption in VS Code:
| - name: Remove badges |
These reflect the current state of the repo, which may be misinterpreted as the state of the VSIX that the user installed.
Let's discuss next week if these badges should show in the extension installation, too.
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/dependency-review.yml) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/scorecard.yml) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/tpip.yml) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/nightly.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be called Nightly like the workflow.
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/blob/main/LICENSE-Apache-2.0) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/blob/main/LICENSE) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/blob/main/LICENSE-GPL-3.0-or-later) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/ci.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow runs test results but is also used for publishing.
Is this reflecting the last run for a specific branch, or for the whole repo?
Fixes
Changes
-Added badges to the README.md file
Screenshots
Checklist